Skip to content

docs: add the missing heading to the effects guide - #70713

Open
erkamyaman wants to merge 1 commit into
angular:mainfrom
erkamyaman:docs-signals-effect-heading
Open

erkamyaman wants to merge 1 commit into
angular:mainfrom
erkamyaman:docs-signals-effect-heading

Conversation

@erkamyaman

Copy link
Copy Markdown
Contributor

The page starts at ## Effects, so it has no H1. adev renders the page heading and the edit link only for an H1, so the page showed neither, unlike the other signals guides.

Promote the top heading to an H1 and move its five sections up one level so the page has no skipped heading levels. Anchors come from the heading text, so only #effects goes away, and the effect() API docs link that pointed at it now links to the page itself.

The page starts at `## Effects`, so it has no H1. adev renders the page
heading and the edit link only for an H1, so the page showed neither,
unlike the other signals guides.

Promote the top heading to an H1 and move its five sections up one level
so the page has no skipped heading levels. Anchors come from the heading
text, so only `#effects` goes away, and the `effect()` API docs link that
pointed at it now links to the page itself.
@pullapprove
pullapprove Bot requested a review from crisbeto September 13, 2026 18:56
@angular-robot angular-robot Bot added the area: docs Related to the documentation label Sep 13, 2026
@ngbot ngbot Bot added this to the Backlog milestone Sep 13, 2026
@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Sep 13, 2026
@JeanMeche
JeanMeche removed the request for review from crisbeto September 13, 2026 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants