Skip to content

feat(router): adds browserUrl input support to router links#66840

Merged
leonsenft merged 1 commit intoangular:mainfrom
SkyZeroZx:router/feature-browser-url
Feb 2, 2026
Merged

feat(router): adds browserUrl input support to router links#66840
leonsenft merged 1 commit intoangular:mainfrom
SkyZeroZx:router/feature-browser-url

Conversation

@SkyZeroZx
Copy link
Contributor

@SkyZeroZx SkyZeroZx commented Jan 30, 2026 •
edited
Loading

Enables specifying a custom browser URL for router links via a new input, allowing navigation to use an explicit browser URL in navigation options.

Closes #66805

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@angular-robot angular-robot bot added detected: feature PR contains a feature commit area: router labels Jan 30, 2026
@ngbot ngbot bot added this to the Backlog milestone Jan 30, 2026
atscott
atscott reviewed Jan 30, 2026
View reviewed changes
packages/router/src/directives/router_link.ts Outdated
* @see {@link NavigationBehaviorOptions#browserUrl}
* @see {@link Router#navigateByUrl}
*/
@Input() set browserUrl(value: UrlTree | string | undefined) {
Copy link
Contributor

@atscott atscott Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can and should just be be an input signal

Copy link
Contributor Author

@SkyZeroZx SkyZeroZx Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@SkyZeroZx
feat(router): adds browserUrl input support to router links
9553e4e 
Enables specifying a custom browser URL for router links via a new input,
allowing navigation to use an explicit browser URL in navigation options.

Closes angular#66805
@SkyZeroZx SkyZeroZx force-pushed the router/feature-browser-url branch from ca9fdd4 to 9553e4e Compare January 30, 2026 03:29
@SkyZeroZx SkyZeroZx marked this pull request as ready for review January 30, 2026 03:31
@pullapprove pullapprove bot requested review from devversion and mmalerba January 30, 2026 04:44
@mmalerba mmalerba removed their request for review January 30, 2026 05:01
@pullapprove pullapprove bot requested a review from mmalerba January 30, 2026 05:01
JeanMeche
JeanMeche approved these changes Jan 30, 2026
View reviewed changes
Copy link
Member

@JeanMeche JeanMeche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release labels Jan 31, 2026
@leonsenft leonsenft merged commit 9505541 into angular:main Feb 2, 2026
23 checks passed
@leonsenft
Copy link
Contributor

leonsenft commented Feb 2, 2026

This PR was merged into the repository. The changes were merged into the following branches:

@thePunderWoman
Copy link
Contributor

thePunderWoman commented Feb 3, 2026

We'll have to revert this change. This caused a number of breakages in unit tests internally.

@SkyZeroZx
Copy link
Contributor Author

SkyZeroZx commented Feb 3, 2026 •
edited
Loading

We'll have to revert this change. This caused a number of breakages in unit tests internally.

Would it be possible to share a general idea about the breakages?
I’m wondering if this could be related to input signal-based behavior usage, or if it’s something else entirely

@atscott
Copy link
Contributor

atscott commented Feb 3, 2026

expect(...).toHaveBeenCalledWith(someExactObject) which now has browserUrl: undefined

@JeanMeche JeanMeche mentioned this pull request Feb 3, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atscott atscott atscott approved these changes

@JeanMeche JeanMeche JeanMeche approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: router detected: feature PR contains a feature commit target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

Support browserUrl from NavigationBehaviorOptions in RouterLink

5 participants

@SkyZeroZx @leonsenft @thePunderWoman @atscott @JeanMeche