fix(router): Ensure createUrlTree does not reuse segments of input#66297
Merged
kirjs merged 1 commit intoangular:mainfrom Jan 6, 2026
Merged
fix(router): Ensure createUrlTree does not reuse segments of input#66297kirjs merged 1 commit intoangular:mainfrom
kirjs merged 1 commit intoangular:mainfrom
Conversation
Mutating the `UrlTree` that is returned by `createUrlTree` can cause the input, which might even be an active route, to be mutated. This ensures the `UrlSegment`s are recreated and do not mutate the input. fixes angular#54624
JeanMeche
approved these changes
Jan 5, 2026
Contributor
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mutating the
UrlTreethat is returned bycreateUrlTreecan cause the input, which might even be an active route, to be mutated. This ensures theUrlSegments are recreated and do not mutate the input.fixes #54624