Skip to content

refactor(ViewPort): @Template -> @Viewport, ViewPort -> ViewContainer#628

Merged
vicb merged 1 commit into
angular:masterfrom
vicb:0212-viewport
Feb 13, 2015
Merged

refactor(ViewPort): @Template -> @Viewport, ViewPort -> ViewContainer#628
vicb merged 1 commit into
angular:masterfrom
vicb:0212-viewport

Conversation

@vicb

@vicb vicb commented Feb 12, 2015

Copy link
Copy Markdown
Contributor

fixes #595

I have tried to not miss any reference to @Template & ViewPort in the code base and docs but I might have forgotten a few of them.

@vicb vicb force-pushed the 0212-viewport branch 2 times, most recently from bfa0a1f to 02ba4e3 Compare February 12, 2015 13:20
@vicb vicb changed the title [WIP] refactor(ViewPort): @Template -> @Viewport, ViewPort -> ViewContainer refactor(ViewPort): @Template -> @Viewport, ViewPort -> ViewContainer Feb 12, 2015
@vicb

vicb commented Feb 12, 2015

Copy link
Copy Markdown
Contributor Author

@tbosch When I try to run the benchmarks locally I get the following error:

Starting selenium standalone server...
[launcher] Running 1 instances of WebDriver
Selenium standalone server started at http://192.168.0.20:49861/wd/hub
Started
F

## BENCHMARK js.ng2.changeDetection.jit
sample size 20
run id 4c8fa120-b2ba-11e4-8a59-ff6f428a1e35
params [
  {
    "name": "numberOfChecks",
    "value": 900000
  }
]
       index |      forceGc |       script |       render |     gcAmount | gcAmountInScript
        ---- |         ---- |         ---- |         ---- |         ---- |         ----

and then no more output.

However this also happens on master, any hint on what could go wrong ?

@vicb vicb mentioned this pull request Feb 12, 2015
2 tasks
@vicb

vicb commented Feb 12, 2015

Copy link
Copy Markdown
Contributor Author

@mhevery I have been able to run the benchmarks thanks to @tbosch (the trick was not to use a bleeding edge of Chrome where protocol has changed). Nothing is broken !

Could you please review the PR ?

@mhevery mhevery added @lgtm action: merge The PR is ready for merge by the caretaker labels Feb 13, 2015
@vicb vicb merged commit 6d23d00 into angular:master Feb 13, 2015
@vicb vicb removed the in progress label Feb 13, 2015
@vicb vicb deleted the 0212-viewport branch February 13, 2015 16:49
@mhevery

mhevery commented Feb 13, 2015

Copy link
Copy Markdown
Contributor

Just FYI, for the docs we have decided to do editor wrap rather than column wrap. The reason for this is when you are adding and removing words you don't have to reflow the line breaks which than generates hard to read diffs.

@vicb

vicb commented Feb 13, 2015

Copy link
Copy Markdown
Contributor Author

@mhevery makes sense

@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename @Template -> to @Viewport

3 participants