refactor(ViewPort): @Template -> @Viewport, ViewPort -> ViewContainer#628
Merged
Conversation
bfa0a1f to
02ba4e3
Compare
Contributor
Author
|
@tbosch When I try to run the benchmarks locally I get the following error: and then no more output. However this also happens on master, any hint on what could go wrong ? |
Contributor
Author
Contributor
|
Just FYI, for the docs we have decided to do editor wrap rather than column wrap. The reason for this is when you are adding and removing words you don't have to reflow the line breaks which than generates hard to read diffs. |
Contributor
Author
|
@mhevery makes sense |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #595
I have tried to not miss any reference to
@Template&ViewPortin the code base and docs but I might have forgotten a few of them.