Skip to content

docs(docs-infra): Display version introduction - #60814

Closed
JeanMeche wants to merge 1 commit into
angular:mainfrom
JeanMeche:docs-api-versions
Closed

docs(docs-infra): Display version introduction#60814
JeanMeche wants to merge 1 commit into
angular:mainfrom
JeanMeche:docs-api-versions

Conversation

@JeanMeche

@JeanMeche JeanMeche commented Apr 9, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

@JeanMeche
JeanMeche marked this pull request as draft April 9, 2025 19:49
@pullapprove
pullapprove Bot requested a review from alxhub April 9, 2025 19:49
@angular-robot angular-robot Bot added area: docs Related to the documentation area: docs-infra Angular.dev application and infrastructure labels Apr 9, 2025
@ngbot ngbot Bot added this to the Backlog milestone Apr 9, 2025
@JeanMeche JeanMeche added adev: preview and removed area: docs-infra Angular.dev application and infrastructure area: docs Related to the documentation labels Apr 9, 2025
@ngbot ngbot Bot modified the milestone: Backlog Apr 9, 2025
@github-actions

github-actions Bot commented Apr 9, 2025 •
edited
Loading

Copy link
Copy Markdown

Deployed adev-preview for e975133 to: https://ng-dev-previews-fw--pr-angular-angular-60814-adev-prev-npodvhz8.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@JeanMeche
JeanMeche force-pushed the docs-api-versions branch from 81ac9ed to 132235b Compare April 9, 2025 20:03
@angular-robot angular-robot Bot added area: docs Related to the documentation area: docs-infra Angular.dev application and infrastructure labels Apr 9, 2025
@ngbot ngbot Bot added this to the Backlog milestone Apr 9, 2025
@JeanMeche
JeanMeche removed the request for review from alxhub April 9, 2025 20:07
@JeanMeche
JeanMeche force-pushed the docs-api-versions branch 6 times, most recently from b35decd to 0b30a12 Compare April 10, 2025 15:31
@JeanMeche
JeanMeche requested a review from jelbourn April 10, 2025 16:38
@JeanMeche
JeanMeche force-pushed the docs-api-versions branch 7 times, most recently from 60f6afb to 40d07d5 Compare April 10, 2025 22:18
@JeanMeche
JeanMeche force-pushed the docs-api-versions branch 2 times, most recently from d9175ae to 8b76a5f Compare April 28, 2025 19:32
@JeanMeche
JeanMeche requested a review from hawkgs April 28, 2025 19:32
josephperrott
josephperrott approved these changes Apr 29, 2025
View reviewed changes

@josephperrott josephperrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thePunderWoman

thePunderWoman commented Apr 29, 2025

Copy link
Copy Markdown
Contributor

I like it but am also confused since the label could have different meanings in different contexts. For the ones that are deprecated, are we saying it's been deprecated since version x? Or was it introduced in version x? stable since version x? It's unclear to me if that's what's meant.

hawkgs
hawkgs reviewed Apr 29, 2025
View reviewed changes
Comment thread adev/shared-docs/pipeline/api-gen/manifest/generate_manifest.ts Outdated
@JeanMeche
JeanMeche force-pushed the docs-api-versions branch 2 times, most recently from 1f719d2 to 9ae1143 Compare May 1, 2025 21:06
@JeanMeche

JeanMeche commented May 1, 2025

Copy link
Copy Markdown
Member Author

@thePunderWoman My plan in a follow up PR to have some kind of history (in a dropdown or other fancy UI) that would say experimental in v X, devPreview in v Y and stable in v Z.

thePunderWoman
thePunderWoman approved these changes May 2, 2025
View reviewed changes

@thePunderWoman thePunderWoman left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

reviewed-for: fw-general, angular-dev, public-api

@pullapprove
pullapprove Bot requested review from alxhub and crisbeto May 2, 2025 09:12
crisbeto
crisbeto approved these changes May 2, 2025
View reviewed changes

@crisbeto crisbeto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate labels May 2, 2025
@JeanMeche
JeanMeche force-pushed the docs-api-versions branch from 9ae1143 to 8e738a6 Compare May 2, 2025 11:28
@JeanMeche

JeanMeche commented May 2, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

reverted the change resource/api.ts/rx_resource as it broke a patch.
#60610 had the same issue and will fix it.

We'll issue a 2nd PR for this specific change once everything is merged.

@JeanMeche
docs(docs-infra): Add version of introduction for APIs
e975133 
For new APIs we'll mention since when a particular API is in its current status (experimental, devPreview, stable)

fixes angular#49668
@JeanMeche
JeanMeche force-pushed the docs-api-versions branch from 8e738a6 to e975133 Compare May 2, 2025 11:34
@JeanMeche

JeanMeche commented May 2, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

Presubmit is "green", the breakage is pre-exisisting.

@AndrewKushnir

AndrewKushnir commented May 2, 2025

Copy link
Copy Markdown
Contributor

This PR was merged into the repository by commit f580318.

The changes were merged into the following branches: main, 20.0.x

AndrewKushnir pushed a commit that referenced this pull request May 2, 2025
@JeanMeche @AndrewKushnir
docs(docs-infra): Add version of introduction for APIs (#60814)
0b0bd36 
For new APIs we'll mention since when a particular API is in its current status (experimental, devPreview, stable)

fixes #49668

PR Close #60814
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Jun 2, 2025

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Jun 2, 2025
@JeanMeche
JeanMeche deleted the docs-api-versions branch June 2, 2025 20:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@hawkgs hawkgs hawkgs left review comments
@thePunderWoman thePunderWoman thePunderWoman approved these changes
@crisbeto crisbeto crisbeto approved these changes
@josephperrott josephperrott josephperrott approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker adev: preview area: docs Related to the documentation area: docs-infra Angular.dev application and infrastructure target: rc This PR is targeted for the next release-candidate

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

6 participants

@JeanMeche @thePunderWoman @AndrewKushnir @hawkgs @crisbeto @josephperrott