Skip to content

refactor(core): move reload method from Resource to WritableResource - #60273

Closed
Humberd wants to merge 1 commit into
angular:mainfrom
Humberd:resource-move-reload-method
Closed

Humberd wants to merge 1 commit into
angular:mainfrom
Humberd:resource-move-reload-method

Conversation

@Humberd

@Humberd Humberd commented Mar 7, 2025

Copy link
Copy Markdown
Member

Now only mutable resources can be reloaded

@pullapprove
pullapprove Bot requested a review from mmalerba March 7, 2025 14:33
@angular-robot angular-robot Bot added the area: core Issues related to the framework runtime label Mar 7, 2025
@ngbot ngbot Bot added this to the Backlog milestone Mar 7, 2025
@JeanMeche

Copy link
Copy Markdown
Member

As this is an change of our public API, we need to update our golden files.

Please run yarn bazel run //packages/core:core_api.accept to update those.

Comment thread packages/common/http/src/resource.ts Outdated
@Humberd
Humberd force-pushed the resource-move-reload-method branch 2 times, most recently from 1a11bca to ad7b579 Compare March 14, 2025 12:24
@Humberd

Humberd commented Mar 14, 2025

Copy link
Copy Markdown
Member Author

As this is an change of our public API, we need to update our golden files.

Please run yarn bazel run //packages/core:core_api.accept to update those.

Done.

@mmalerba
mmalerba requested review from pkozlowski-opensource and removed request for mmalerba March 18, 2025 03:41
@Humberd
Humberd force-pushed the resource-move-reload-method branch from ad7b579 to 386b067 Compare March 18, 2025 12:15
@pullapprove
pullapprove Bot requested review from AndrewKushnir and kirjs March 20, 2025 22:54

@alxhub alxhub left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-For: public-api

@alxhub

alxhub commented Mar 20, 2025

Copy link
Copy Markdown
Member

Blocked while g3 is patched.

@kirjs kirjs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-For: public-api

@Humberd
Humberd force-pushed the resource-move-reload-method branch from 386b067 to 610c0e0 Compare March 21, 2025 12:31
@alxhub alxhub added the target: major This PR is targeted for the next major release label Mar 21, 2025
@Humberd

Humberd commented Mar 28, 2025

Copy link
Copy Markdown
Member Author

Close in favour of #60610

@Humberd Humberd closed this Mar 28, 2025
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Apr 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area: core Issues related to the framework runtime state: blocked target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants