Skip to content

docs: Add DestroyRef and takeUntilDestroyed sections to lifecycle doc#50042

Closed
dylhunn wants to merge 1 commit intoangular:mainfrom
dylhunn:destroy-guide
Closed

docs: Add DestroyRef and takeUntilDestroyed sections to lifecycle doc#50042
dylhunn wants to merge 1 commit intoangular:mainfrom
dylhunn:destroy-guide

Conversation

@dylhunn
Copy link
Contributor

@dylhunn dylhunn commented Apr 27, 2023

These two concepts are a crucial addition to component destruction, and are added to the existing lifecycle doc (which is retitled more generally).

@ngbot ngbot bot added this to the Backlog milestone Apr 27, 2023
@dylhunn dylhunn added action: review The PR is still awaiting reviews from at least one requested reviewer aio: preview labels Apr 27, 2023
@github-actions
Copy link

github-actions bot commented Apr 27, 2023 •
edited
Loading

Deployed aio for 45f3190 to: https://ng-dev-previews-fw--pr-angular-angular-50042-zwsbd2mt.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@JeanMeche
Copy link
Member

JeanMeche commented Apr 27, 2023 •
edited
Loading

Hi !
Maybe mention that takeUntilDestroyed is still a developer preview ? (What's the reasionning behind not making it public when DestroyRef is public btw ?)

@dylhunn dylhunn requested review from alxhub and jelbourn April 27, 2023 16:35
@alxhub alxhub modified the milestones: Backlog, v16-final Apr 28, 2023
JeanMeche
JeanMeche reviewed Apr 28, 2023
View reviewed changes
jelbourn
jelbourn reviewed Apr 28, 2023
View reviewed changes
@dylhunn
docs: Add DestroyRef and takeUntilDestroyed sections to lifecycle…
45f3190 
… doc

These two concepts are a crucial addition to component destruction, and are added to the existing lifecycle doc (which is retitled more generally).
@dylhunn
Copy link
Contributor Author

dylhunn commented Apr 28, 2023 •
edited
Loading

Hi ! Maybe mention that takeUntilDestroyed is still a developer preview ? (What's the reasionning behind not making it public when DestroyRef is public btw ?)

We added this @JeanMeche.

alxhub
alxhub approved these changes Apr 28, 2023
View reviewed changes
jelbourn
jelbourn approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dylhunn dylhunn added action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 28, 2023
@alxhub
Copy link
Member

alxhub commented May 1, 2023

This PR was merged into the repository by commit 50a4a7c.

alxhub pushed a commit that referenced this pull request May 1, 2023
@dylhunn @alxhub
docs: Add DestroyRef and takeUntilDestroyed sections to lifecycle…
67abb3f 
… doc (#50042)

These two concepts are a crucial addition to component destruction, and are added to the existing lifecycle doc (which is retitled more generally).

PR Close #50042
@alxhub alxhub closed this in 50a4a7c May 1, 2023
sr5434 pushed a commit to sr5434/angular that referenced this pull request May 3, 2023
@dylhunn @sr5434
docs: Add DestroyRef and takeUntilDestroyed sections to lifecycle…
89eb7d7 
… doc (angular#50042)

These two concepts are a crucial addition to component destruction, and are added to the existing lifecycle doc (which is retitled more generally).

PR Close angular#50042
@bougwal bougwal mentioned this pull request May 3, 2023
Closed
1 task
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Jun 1, 2023

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JeanMeche JeanMeche JeanMeche left review comments

@alxhub alxhub alxhub approved these changes

+1 more reviewer

@jelbourn jelbourn jelbourn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate

Projects

None yet

Milestone

v16-final

Development

Successfully merging this pull request may close these issues.

4 participants

@dylhunn @JeanMeche @alxhub @jelbourn