@dylhunn just wanted to share some test cases that I think would be great to have. Some of them after already fully covered (for ex. "Template-driven Forms" -> Case 2), I listed the cases anyways just to have a full picture (for myself, so I'm not missing anything). I also mentioned what we can look for in the tests, to make sure we do not assign extra classes to elements that are not expected to have that class.

Reactive Forms

1. Simple case:

<form [formGroup]="group">
 <input [formControl]="control">
</form>

We can check that:

• <form> has ng-submitted class after submission and has no class after reset
• <input> has no ng-submitted class before submission and after reset

2. With nested formGroups:

<form [formGroup]="group">
   <div [formGroup]="nestedGroup">
     <input [formControl]="control">
   </div>
</form>

We can check that:

• <form> has ng-submitted class after submission and has no class after reset
• <div> has no ng-submitted class before submission and after reset
• <input> has no ng-submitted class before submission and after reset

3. With nested formArrayNames:

<form [formGroup]="group">
   <div [formArrayName]="name">
     <input [formControl]="control">
   </div>
</form>

We can check that:

• <form> has ng-submitted class after submission and has no class after reset
• <div> has no ng-submitted class before submission and after reset
• <input> has no ng-submitted class before submission and after reset

4. Similar to a test case above, but with nested formGroupNames:

<form [formGroup]="group">
   <div [formGroupName]="name">
     <input [formControl]="control">
   </div>
</form>

We can check that:

• <form> has ng-submitted class after submission and has no class after reset
• <div> has no ng-submitted class before submission and after reset
• <input> has no ng-submitted class before submission and after reset

Template-driven Forms

1. Simple case:

<form>
 <input [(ngModel)]="control">
</form>

We can check that:

• <form> has ng-submitted class after submission and has no class after reset
• <input> has no ng-submitted class before submission and after reset

2. With nested ngModelGroups:

<form>
  <div ngModelGroup="group">
    <input [(ngModel)]="control">
  </div>
</form>

We can check that:

• <form> has ng-submitted class after submission and has no class after reset
• <div> has no ng-submitted class before submission and after reset
• <input> has no ng-submitted class before submission and after reset

@dylhunn quick note: we should also update the relevant section of the aio/content/guide/forms.md file to include information on the ng-submitted class.

Merging is currently blocked on a g3 presubmit issue, as described internally in b/189261737.

Some updates:

• Real google3 breakage is fixed (see b/189261737 and cl/377141465)
• Some targets still fail to build in the presubmit; however these breakages are present in a clean client and can be ignored

This PR caused breakages in google3 and was rolled back. We'll need to run a TGP with these changes to verify there are no issues.

The issue seems to have been that ViewEngine chokes on the spread operator as used in the host binding. I'll investigate this more separately, but it should be fixed here for now.

After re-running flakes, TGP looks good (googler link).

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}