feat(forms): add types to Forms - both controls and builder#32655
Closed
pmccloghrylaing wants to merge 1 commit intoangular:masterfrom
Closed
feat(forms): add types to Forms - both controls and builder#32655pmccloghrylaing wants to merge 1 commit intoangular:masterfrom
pmccloghrylaing wants to merge 1 commit intoangular:masterfrom
Conversation
Contributor
Author
|
Similar to #32450 but should have better typing for FormArray & FormGroup controls and values. |
43d43bd to
849de48
Compare
849de48 to
5d30b72
Compare
Contributor
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #13721
What is the new behavior?
Forms can be made to be strongly typed.
Does this PR introduce a breaking change?
Other information
This approach includes the type of the child controls in FormGroup and FormArray and then infers the "value" from that. This avoids issues where a FormControl might hold an array or object value. It uses a lot of conditional typing within the form builder to infer the correct type of the returned FormControl, FormGroup or FormArray.