Skip to content

docs(animation): add plunker for sequence#11775

Closed
Foxandxss wants to merge 1 commit intoangular:masterfrom
Foxandxss:animation-live-example
Closed

docs(animation): add plunker for sequence#11775
Foxandxss wants to merge 1 commit intoangular:masterfrom
Foxandxss:animation-live-example

Conversation

@Foxandxss
Copy link
Copy Markdown
Member

This is the companion PR for angular/angular.io#2425

We can remove all the hardcoded plunker links in the API docs with the new {@liveExample} tag.

We can do:

{@liveExample core/animation/ts/dsl}


Embedded mode

{@liveExample core/animation/ts/dsl embedded}

Closed:

Opened:


Not hidden but behind an img:

{@liveExample core/animation/ts/dsl embedded -img="devguide/ngmodule/final-plunker.png"}

@vicb
Copy link
Copy Markdown
Contributor

vicb commented Sep 20, 2016

Nice !

Do we have some guideline of which of those 3 versions we should use for API docs ?

edit: And should we use example or liveExample ?

@Foxandxss
Copy link
Copy Markdown
Member Author

We do not. I leave that to your team's choice. I guess we shall experiment to see which one works the better.

@vsavkin vsavkin added the area: animations legacy animations package only. Otherwise use area: core. label Oct 4, 2016
@Foxandxss Foxandxss closed this Apr 11, 2017
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area: animations legacy animations package only. Otherwise use area: core. cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants