Skip to content
This repository was archived by the owner on Jan 14, 2019. It is now read-only.

Xdist compatibility#80

Merged
mavlyutov merged 19 commits into
masterfrom
xdist_compat
Jan 11, 2016
Merged

Xdist compatibility#80
mavlyutov merged 19 commits into
masterfrom
xdist_compat

Conversation

@pupssman

Copy link
Copy Markdown
Contributor

Fixes #8 via refactoring of the allure handlers process.

@pupssman

Copy link
Copy Markdown
Contributor Author

The tests fail for now, but not entirely.
Volunteers wanted for alpha-testing on real suites.

@pupssman

Copy link
Copy Markdown
Contributor Author

This is it -- now all tests are run locally (wtih no xdist) and with xdist 's -n 1 -- and that means that all the features work totally same with xdist!

@FuriousDuck @mavlyutov @hmax @alvassin @bayandin @dimonb please take a look and try this one branch with your test-suite -- real-data-base feedback would be priceless.

What is more important -- so far code is a little bit screwed up in regards to previously-used architecture -- the Common module is not that used, some hacking is done in the pytest plugin, etc, etc.
Any architectural advice would be greatly appreciated.

Comment thread allure/utils.py

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why in parentheses?

@leon-id

leon-id commented Oct 23, 2015

Copy link
Copy Markdown

Volunteers wanted for alpha-testing on real suites.

mine projects build okay with xdist enabled, their allure reports look okay too.
thanks for the long-awaited feature!

@pupssman

Copy link
Copy Markdown
Contributor Author

Okay, so the important part is about the internal workings of the implementation.
How shall we rule the fate of allure.common.AllureImpl? The data flow it was designed for is no longer the case in the py.test plugin -- should we keep that "basic" implementation for the sake of, say, allure-nose support? Or should it be re-imagined to actually mean something (be it of less sense than now)?

mavlyutov added a commit that referenced this pull request Jan 11, 2016
@mavlyutov mavlyutov merged commit d0eb0c3 into master Jan 11, 2016
@mavlyutov mavlyutov deleted the xdist_compat branch January 11, 2016 15:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants