Skip to content
This repository was archived by the owner on Jan 14, 2019. It is now read-only.

minor log change#51

Closed
serhatbolsu wants to merge 2 commits into
allure-framework:masterfrom
serhatbolsu:master
Closed

minor log change#51
serhatbolsu wants to merge 2 commits into
allure-framework:masterfrom
serhatbolsu:master

Conversation

@serhatbolsu

Copy link
Copy Markdown

attach first argument is text, second is the path string.

attach first argument is text, second is the path string.
@qatools-ci

Copy link
Copy Markdown

Can one of the admins verify this patch?

@pupssman

pupssman commented Dec 4, 2014

Copy link
Copy Markdown
Contributor

Wait, the AllureImpl has method attach(title, contents, attach_type).

@serhatbolsu

Copy link
Copy Markdown
Author

Exactly, that is the change in log

@pupssman

pupssman commented Dec 4, 2014

Copy link
Copy Markdown
Contributor

Well, the diff in question only changes a bit of docstring and, IMO, changes it improperly. First param is some file, which is intened as the attachment's title, and second parameter is quick brown fox .., that goes to contents

@serhatbolsu

Copy link
Copy Markdown
Author

I took some file as file path, in the case you told I was wrong, and will roll back

@pupssman pupssman closed this Feb 5, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants