Merge event configuration instead of replace#43
Merged
baev merged 1 commit intoMar 7, 2018
Conversation
|
|
|
I wonder if this logics should rather be a part of |
Contributor
Author
|
@eduard-sukharev this will be a huge refactoring in https://github.com/allure-framework/allure-php-commons/ and all adapters, but looks like a good idea. Here I just want to fix a bug which made us downgrade to 1.2.5 |
Contributor
Author
|
@baev can we merge this fix? |
baev
approved these changes
Mar 7, 2018
Member
|
thanks to all of you guys, sorry for the delay |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to keep class annotation in place we have to fist populate all annotations on class and method and then them altogether to construct
AnnotationManagerFix #42