Add support for custom ignored annotations#35
Conversation
Currently, custom ignored annotations are not added, hence an exception can be thrown (i.e. in case of `dataprovider` annotation). I suggest to add support for custom ignored annotations, as defined in configuration file.
|
@baev this is tested and works as expected. Can you please take a look and merge if everything is OK? Thank you! |
|
is there any way to make AllureAdaptor skip all unknown annotations? Other way it seems hacky |
|
|
|
I mean why do we need to specify ignored annotations? If there is no way to process only allure annotations can we catch the exception and skip it? |
|
Docblock parser throws an exception in this case: Anyway, Codeception adapter already includes a list of annotations that should be ignored by the parser (mostly coming from PHPUnit). If we could add @baev what do you think? |
|
I am fine with the current patch, just asking is there any better solution (that will work for all the users without additional configuration). If not, I'll merge it |
|
I don't see a better solution in the adapter, as the exception is coming from Doctrine parser. Even custom ignored annotations should be supported or the 2 annotations that I mentioned above should be added in |
Currently, custom ignored annotations are not added, hence an exception can be thrown (i.e. in case of
dataproviderannotation). I suggest to add support for custom ignored annotations, as defined in configuration file.Fixes #32