add versions, environments and improve test coverage #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilt-in requests package
kennydaniel
reviewed
May 13, 2022
| def getBuildLogs(self, user, algo, client): | ||
| api_response = client.algo(user + '/' + algo).build_logs() | ||
|
|
||
| if "error" in api_response: |
Contributor
There was a problem hiding this comment.
what will happen here if there is an error, now that you remove error handling?
Contributor
Author
There was a problem hiding this comment.
it will just raise the error as per the build_logs() endpoint, previously there was no error handling in the internal build_logs() endpoint, if it was a 500 we needed that to be handled here
kennydaniel
approved these changes
May 13, 2022
Contributor
kennydaniel
left a comment
There was a problem hiding this comment.
Overall looks good. Nice refactoring on the getJsonHelper.
Note that this is a breaking python api change so will need major version. I support the changes though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a bunch (sorry!)
It strips out most of the openapi spec generated client logic; and instead hardcodes API paths.
It also replaces the autogenerated class objects with json response objects, but keeps error handling the same.
This unbreaks the following paths with gitlab / bitbucket based SCMs:
algo.versions()
algo.info()
algo.builds()
We also added the following endpoints:
algo.versions()
algo.exists()
more test coverage may be required.