AML- 8 DATA API support for automatically zipping/unzipping nested directories#112
Merged
AML- 8 DATA API support for automatically zipping/unzipping nested directories#112
Conversation
…e files; with tests
lemonez
reviewed
Oct 1, 2021
lemonez
reviewed
Oct 1, 2021
lemonez
previously approved these changes
Oct 1, 2021
Contributor
lemonez
left a comment
There was a problem hiding this comment.
just added a few docstrings from the PR content
Co-authored-by: lemonez <36384768+lemonez@users.noreply.github.com>
Co-authored-by: lemonez <36384768+lemonez@users.noreply.github.com>
lemonez
reviewed
Oct 4, 2021
lemonez
suggested changes
Oct 4, 2021
Contributor
lemonez
left a comment
There was a problem hiding this comment.
just this docstring update, looks good.
lemonez
approved these changes
Oct 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the following two methods
getAsZip()andputAsZip(path)to theDataFileclass.putAsZip()- accepts both a single file, or a directory containing other files and directories; will zip everything into a zipfile and upload that to the data API location defined by the DataFile object.getAsZip()- expects the DataFile object to point to a zip compatible data API location, downloads and decompresses file / directories, and either returns the directory or a path to the file; depending on if a directory or file was zipped.This is useful for existing customer engagements, but also directory structures are required for
transformersandtensorflowworkflows.