Conversation
Apt.py
Outdated
| @@ -0,0 +1,66 @@ | |||
| """locate adapter extension | |||
There was a problem hiding this comment.
Description is missing.
| __author__ = "Harindu Dilshan" | ||
| __dependencies__ = ['apt','gksu','pkexec'] | ||
|
|
||
| if which("apt") is None: |
There was a problem hiding this comment.
maybe using apt-get is better since apt is a userfriendly frontend that may break backward compatibility
| __version__ = "1.0" | ||
| __trigger__ = "apt" | ||
| __author__ = "Harindu Dilshan" | ||
| __dependencies__ = ['apt','gksu','pkexec'] |
There was a problem hiding this comment.
why dont you just prepend the command with sudo? sudo is way mor portable, in fact gksu is not available most of the times
There was a problem hiding this comment.
pkexec is actually not needed
|
|
||
| UpdateActions = [TermAction("Update database in Terminal", ["sudo", "apt", "update"])] | ||
|
|
||
| if gksu is not None: |
There was a problem hiding this comment.
I'd recommend to remove this. You dont want to mess with the package manager. users should always see the output of it.
There was a problem hiding this comment.
which would remove gksu from the dependencies. I recommend this anyway because the workflow is exactly the same but there is one additional dependency.
| if query.isTriggered: | ||
| if len(query.string) > 2: | ||
| # pattern = re.compile(query.string, re.IGNORECASE) | ||
| shell_cmd = ["apt-cache" ,"search"] |
There was a problem hiding this comment.
apt-cache is not in the deps list. I am not good with debian. If it is always installed thats fine. if not users should know it.
|
I dont know how to do this, but could you please finish the change request when you made your changes? Last time I did not recognize your changes since the PR overview told me that there are still changes requested.
|
|
@harindu95? R u still there? |
|
Seems to be abandoned by OP. |
No description provided.