Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: adobe/aem-core-forms-components
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: adobe/aem-core-forms-components
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: dev
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 7 commits
  • 48 files changed
  • 9 contributors

Commits on Apr 29, 2026

  1. Updating style selectors for theme editor

    Muskan Gupta authored and ci-build committed Apr 29, 2026
    Configuration menu
    Copy the full SHA
    34df6f4 View commit details
    Browse the repository at this point in the history
  2. Updating style selectors further

    Muskan Gupta authored and ci-build committed Apr 29, 2026
    Configuration menu
    Copy the full SHA
    21e83f2 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2026

  1. Merge pull request #1872 from adobe/fix/FORMS-25246-fieldtype-containers

    feat(dialog): add fieldType hidden field to container component dialogs
    vdua authored May 4, 2026
    Configuration menu
    Copy the full SHA
    6b26ab2 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2026

  1. Merge pull request #1851 from adobe/ThemeSelectors

    Updating style selectors for theme editor CC
    muskgupta authored May 19, 2026
    Configuration menu
    Copy the full SHA
    962b800 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2026

  1. fix(checkbox): guard against null uncheckedValue when JCR property is…

    … absent (#1892)
    
    When enableUncheckedValue=true but uncheckedValue is not stored in JCR
    (e.g. because the content push mechanism skipped an empty-string value),
    AbstractCheckboxImpl built an enum array with null as the second element.
    The AFB runtime calls .toString() on every enum value at init time, so
    enum: [".", null] caused TypeError: Cannot read properties of null
    (reading 'toString') in createFormInstance / RuleEngineWorker, crashing
    the form before any screen rendered.
    
    Fix: default safeUncheckedValue to "" when the JCR property is absent.
    Add a regression test with a fixture that omits uncheckedValue from JCR.
    
    Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
    rismehta and claude authored May 29, 2026
    Configuration menu
    Copy the full SHA
    672b1a4 View commit details
    Browse the repository at this point in the history
  2. feat(af-core): FORMS-25463 expose cq:annotations parallel to fd:dor (#…

    …1883)
    
    * feat(af-core): FORMS-25463 expose cq:annotations parallel to fd:dor
    
    Add getCqAnnotations() on AbstractFormComponentImpl that reads the
    cq:annotations child resource (a sibling of fd:dorContainer on the
    component node) and exposes its child annotations as a per-annotation
    map keyed by node name. Each entry carries color, text, x, y, optional
    state/resolvedBy/resolvedAt and the JCR audit fields. Null fields are
    stripped so the serialised shape matches the JCR content exactly.
    
    Wire the call into getProperties() so the resulting map is placed
    under properties.cq:annotations -- parallel to fd:dor / fd:path /
    fd:associate -- not nested inside dorContainer. Returns null when no
    cq:annotations child exists; Jackson then omits the key, keeping the
    output non-breaking for forms without annotations.
    
    * fix(af-core): FORMS-25463 exclude cq:annotations from getCustomProperties
    
    getCustomProperties() reads all non-reserved JCR properties from the
    resource ValueMap and includes them as raw Strings. cq:annotations is
    not in the excluded-prefix list ("fd:", "jcr:", "sling:"), so a stale
    String-typed cq:annotations property on the node was leaking through and
    appearing as a double-serialised JSON string in the GET IC response.
    
    Adding an explicit key exclusion for CUSTOM_ANNOTATIONS_PROPERTY_WRAPPER
    ensures the property is handled exclusively by getCqAnnotations(), which
    returns it as Map<String,Object> and produces proper nested JSON.
    
    Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
    
    * feat(af-core): FORMS-25463 ic annotations in authoring crispr only
    
    * style(af-core): FORMS-25463 apply formatter to AbstractFormComponentImpl
    
    Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
    
    * feat(af-core): FORMS-25463 ic annotations in authoring crispr only
    
    * fix(af-core): FORMS-25463 remove formatting changes, keep only cq:annotations feature
    
    * FORMS-25463: blocking publish of cq:annotations
    
    * FORMS-25463: adding tests
    
    * FORMS-25463: adding more tests for codecov
    
    * FORMS-25463: formatting fix
    
    * FORMS-25463: PR comments incorporate plus tests
    
    ---------
    
    Co-authored-by: Prateek Awasthi <prateekawast@adobe.com>
    Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
    3 people authored May 29, 2026
    Configuration menu
    Copy the full SHA
    1a0476d View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2026

  1. File input extension support in v4 and reset fileInput on resetting (#…

    …1849)
    
    * file input extension suppport in v4 and reset fileput on resetting
    
    * test cases added
    
    * test case fixed
    
    ---------
    
    Co-authored-by: Rajat Khurana <rajatkhurana@adobe.com>
    rajatofficial and rajatkhurana-adobe authored Jun 11, 2026
    Configuration menu
    Copy the full SHA
    bacee5b View commit details
    Browse the repository at this point in the history
Loading