start to make the model more OO by adding a .can_allocate() method to Stock

hjwp · hjwp · commit f0e0c55271f0 · 2019-02-05T10:15:06.000Z
diff --git a/domain_model.py b/domain_model.py
@@ -15,10 +15,9 @@ def allocate(self, stock, shipments):
         self.allocations = {}
         for source in [stock] + shipments:
             allocation = {
-                key: source
-                for key in self.lines
-                if key in source.lines
-                and source.lines[key] > self.lines[key]
+                sku: source
+                for sku, quantity in self.lines.items()
+                if source.can_allocate(sku, quantity)
             }
             if set(allocation.keys()) == set(self.lines):
                 self.allocations = allocation
@@ -32,4 +31,7 @@ class Stock:
     lines: dict
     eta: date = None
 
+    def can_allocate(self, sku, quantity):
+        return sku in self.lines and self.lines[sku] > quantity
+
 
