handlers now have all and only explicit dependencies [handler_with_explicit_dependency]

hjwp · hjwp · commit 8474e8dae6cf · 2020-03-05T19:58:45.000Z
diff --git a/src/allocation/service_layer/handlers.py b/src/allocation/service_layer/handlers.py
@@ -1,8 +1,7 @@
 #pylint: disable=unused-argument
 from __future__ import annotations
 from dataclasses import asdict
-from typing import TYPE_CHECKING
-from allocation.adapters import email, redis_eventpublisher
+from typing import Callable, TYPE_CHECKING
 from allocation.domain import commands, events, model
 from allocation.domain.model import OrderLine
 if TYPE_CHECKING:
@@ -38,6 +37,7 @@ def allocate(
         product.allocate(line)
         uow.commit()
 
+
 def reallocate(
         event: events.Deallocated, uow: unit_of_work.AbstractUnitOfWork
 ):
@@ -46,6 +46,7 @@ def reallocate(
         product.events.append(commands.Allocate(**asdict(event)))
         uow.commit()
 
+
 def change_batch_quantity(
         cmd: commands.ChangeBatchQuantity, uow: unit_of_work.AbstractUnitOfWork
 ):
@@ -58,18 +59,18 @@ def change_batch_quantity(
 #pylint: disable=unused-argument
 
 def send_out_of_stock_notification(
-        event: events.OutOfStock, uow: unit_of_work.AbstractUnitOfWork,
+        event: events.OutOfStock, send_mail: Callable,
 ):
-    email.send(
+    send_mail(
         'stock@made.com',
         f'Out of stock for {event.sku}',
     )
 
 
 def publish_allocated_event(
-        event: events.Allocated, uow: unit_of_work.AbstractUnitOfWork,
+        event: events.Allocated, publish: Callable,
 ):
-    redis_eventpublisher.publish('line_allocated', event)
+    publish('line_allocated', event)
 
 
 def add_allocation_to_read_model(
@@ -83,6 +84,7 @@ def add_allocation_to_read_model(
         )
         uow.commit()
 
+
 def remove_allocation_from_read_model(
         event: events.Deallocated, uow: unit_of_work.SqlAlchemyUnitOfWork,
 ):
