Conversation
Too -> to
Fix typos in README
[CLEANUP] styles/
[FIX] VIMEO usage
Issues with speech were discovered in Debian 11.6 (Bullseye) with the [espeak](https://espeak.sourceforge.net/) package. * Firefox and [Chromium](https://www.chromium.org/Home/) do not respect the volume parameter; the configured phrase "Hi!" is spoken for every instances of AblePlayer. * Google Chrome will lock speech synthesis for the browser if the rate parameter is changed. Speech synthesis will be locked until the affected tab is closed. Browsers are consistently silent when SpeechSynthesis initialized with `\x20` (space). Silent initialization allows for the removal of volume and rate parameters, improving the likelyhood of universal speech support. Changes were tested against all listed AblePlayer browsers except for Windows.
Added a screenshot of the player
jeanem
reviewed
Jun 2, 2025
Contributor
There was a problem hiding this comment.
@joedolson - I confirmed that the original code from the #600 PR for fixing the unbind event issue is present in this PR. Also I pulled this PR locally and tested this particular fix and looks like it is good to go. Thanks!
Member
Author
|
Thanks, @jeanem! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an update to PR 575, , attempting to identify the functional changes in that PR.
@jeanem If you have a chance, can you confirm whether I caught everything you'd changed in the previous PR? The number of formatting changes make it difficult to be sure.