Skip to content

Switch controller buttons back to button elements #672

@joedolson

Description

@joedolson

All of Able Player's buttons were changed to div elements with role="button" in 51fdbd8, to resolve issues with high contrast mode.

I know that there are other solutions to this problem, and I feel like it would be better to use native button elements and solve the issue in CSS.

This could result in CSS compatibility problems with styling, but overall I still think it would be better.

To start, I might need to make it an option (possibly enabled by default), but allow people to opt out while they get their styles adapted (or while I fix bugs, if possible.)

But by version 5.0, I'd like to be solely using real button elements.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions