No actionable comments were generated in the recent review. 🎉

Summary by CodeRabbit

• Chores
  • Improved Redis connection management configuration to enhance system reliability in distributed deployment environments.

Walkthrough

Added CONNECTION_FACTORY configuration option to Django Redis Sentinel cache settings to explicitly specify SentinelConnectionFactory for Sentinel-based Redis connection management. This is a single-line configuration update with no logic changes.

Changes

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Test Results

Greptile Summary

This PR adds the missing "CONNECTION_FACTORY": "django_redis.pool.SentinelConnectionFactory" key to the Django CACHES config for Redis Sentinel mode. Without it, the default ConnectionFactory was used, which attempted to create SentinelConnectionPool via from_url() — but SentinelConnectionPool.__init__() requires service_name and sentinel_manager to be injected explicitly, causing a TypeError crash during migrations.

Key changes:

• Adds one line inside the if REDIS_SENTINEL_MODE: branch so SentinelConnectionFactory handles pool creation properly by injecting the required Sentinel-specific arguments
• The fix is narrowly scoped and does not affect the standalone Redis code path

Note: CONNECTION_POOL_CLASS: "redis.sentinel.SentinelConnectionPool" (added in the prior PR #1854) is now redundant alongside SentinelConnectionFactory, since the factory creates SentinelConnectionPool internally by default. This is harmless, but could be cleaned up in a follow-up for clarity.

Confidence Score: 5/5

• This PR is safe to merge — it is a single-line targeted fix within a Sentinel-only code branch that resolves a documented crash.
• The change is minimal (one line), correctly placed within the if REDIS_SENTINEL_MODE: guard, and directly addresses the root cause described in the PR. Standalone Redis mode is completely unaffected. The added key (CONNECTION_FACTORY) is the canonical way to configure a custom connection factory in django_redis and SentinelConnectionFactory is the correct class for this use case.
• No files require special attention.

Important Files Changed

Sequence Diagram

sequenceDiagram
    participant DjangoApp as Django App
    participant RedisCache as django_redis RedisCache
    participant Factory as ConnectionFactory (before fix)
    participant SentinelFactory as SentinelConnectionFactory (after fix)
    participant Pool as SentinelConnectionPool
    participant Sentinel as Redis Sentinel

    Note over DjangoApp,Sentinel: Before fix (crashes on migration)
    DjangoApp->>RedisCache: cache.get(key)
    RedisCache->>Factory: get_connection_pool(url)
    Factory->>Pool: SentinelConnectionPool.from_url(url)
    Pool-->>Factory: TypeError: missing service_name & sentinel_manager
    Factory-->>DjangoApp: ❌ Crash

    Note over DjangoApp,Sentinel: After fix (works correctly)
    DjangoApp->>RedisCache: cache.get(key)
    RedisCache->>SentinelFactory: get_connection_pool(url)
    SentinelFactory->>SentinelFactory: parse service_name from LOCATION URL
    SentinelFactory->>Pool: SentinelConnectionPool(service_name, sentinel_manager)
    Pool->>Sentinel: connect to sentinel host:port
    Sentinel-->>Pool: return master address
    Pool-->>SentinelFactory: pool ready
    SentinelFactory-->>DjangoApp: ✅ Connection established

_{Last reviewed commit: 0d416db}

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud