Fix for Incorrect File Download Name "GetAttachment"#1323
Merged
w8tcha merged 3 commits intoYAFNET:masterfrom Oct 15, 2024
Merged
Fix for Incorrect File Download Name "GetAttachment"#1323w8tcha merged 3 commits intoYAFNET:masterfrom
w8tcha merged 3 commits intoYAFNET:masterfrom
Conversation
|
Thanks so much for opening your first PR here! |
Member
|
Can you revert the second commit, this would break the code the issue with building in release mode is already fixed. |
This reverts commit d0d3eba.
Author
|
Yes, of course |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
File Download Name: Previously, files were being downloaded to the user's computer with the default name "GetAttachment". The update ensures that files are now downloaded with their correct, intended names, improving the user experience and preventing confusion.
Release Mode Build Issue: The application was not building correctly in "Release" mode. This pull request includes the necessary adjustments to ensure that the application can be successfully built and deployed in Release mode.
Please review the changes and provide feedback. Thank you!