Twenty Twenty-One: Fix button text color in blocks with a custom background - #13707
R1shabh-Gupta wants to merge 1 commit into
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
@R1shabh-Gupta Tested in WordPress playground 
|
t-hamano
left a comment
There was a problem hiding this comment.
LGTM! I think this is exactly the right correction.
@sabernhardt, can you take a look at this when you have time?
Fixes invisible button text in Twenty Twenty-One when a button (Search, File, or a plain button) sits inside a block with a custom background color.
The button-style mixin falls back to the same color for both the button's text and its background when no local color variable is set, which happens with custom (non-palette) background colors. This changes the text fallback to match the one the Button block already uses, so text stays readable.
Trac ticket: https://core.trac.wordpress.org/ticket/63245
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5
Used for: Code Review
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.