Build/Test Tools: Use createMock() in WP_Upgrader tests - #13458
Closed
Soean wants to merge 1 commit into
Closed
Conversation
Replace `getMockBuilder( $class )->getMock()` with the shorter `createMock( $class )` in the `WP_Upgrader` test setup. Neither mock configures constructor arguments or a method list, so the builder adds nothing here, and `createMock()` is the form already used across the rest of the test suite. `createMock()` additionally disables the original constructor. This is safe for both mocks: `WP_Filesystem_Base` has no constructor, and while `WP_Upgrader_Skin::__construct()` populates `$this->options`, the tests only ever stub methods and never read that property. The remaining `getMockBuilder()` calls in the test suite are left untouched, as they all configure constructor arguments or mocked methods.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
lancewillett
self-requested a review
September 9, 2026 13:31
lancewillett
approved these changes
Sep 9, 2026
wporg-sync
pushed a commit
that referenced
this pull request
Sep 9, 2026
Use `createMock()` for the upgrader skin and filesystem mocks. These test doubles need no custom builder configuration, original constructor, or cloning behavior. Developed in: #13458 Props soean. See #65819. git-svn-id: https://develop.svn.wordpress.org/trunk@63562 602fd350-edb4-49c9-b593-d223f7449a82
Member
wporg-sync
pushed a commit
to WordPress/WordPress
that referenced
this pull request
Sep 9, 2026
Use `createMock()` for the upgrader skin and filesystem mocks. These test doubles need no custom builder configuration, original constructor, or cloning behavior. Developed in: WordPress/wordpress-develop#13458 Props soean. See #65819. Built from https://develop.svn.wordpress.org/trunk@63562 git-svn-id: http://core.svn.wordpress.org/trunk@62738 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
getMockBuilder( $class )->getMock()with the shortercreateMock( $class )in theWP_Upgradertest setup. Neither mock configures constructor arguments or a method list, so the builder adds nothing here, andcreateMock()is the form already used across the rest of the test suite.The remaining
getMockBuilder()calls in the test suite are left untouched, as they all configure constructor arguments or mocked methods and therefore genuinely need the builder.Trac ticket: https://core.trac.wordpress.org/ticket/65819
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.