Skip to content

Bump minimum PHP requirement from 7.2 to 7.4 #2469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
westonruter merged 32 commits into from
May 18, 2026
Merged

Bump minimum PHP requirement from 7.2 to 7.4 #2469

Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
382ce6c
Bump minimum PHP version to 7.4 in composer.json
westonruter May 8, 2026
e9ce2ca
Bump PHPCS testVersion to 7.4-
westonruter May 8, 2026
2a5cc3f
Bump plugin header Requires PHP from 7.2 to 7.4
westonruter May 8, 2026
872f9c5
Drop PHP 7.2 and 7.3 from the unit-test matrix
westonruter May 8, 2026
0e0671f
Update CONTRIBUTING.md and AGENTS.md to reference PHP 7.4
westonruter May 8, 2026
619d91b
Update phpstan.neon.dist comment to reference PHP 7.4
westonruter May 8, 2026
cd44261
Drop PHP 7.2/7.3 array_merge empty-input guard
westonruter May 8, 2026
04e1f38
Reindent speculation-rules heredoc closer using PHP 7.3+ flexible her…
westonruter May 8, 2026
6017bd9
Allow @var docblocks alongside native property type hints
westonruter May 8, 2026
6d94c56
Add native typed properties to OD_HTML_Tag_Processor
westonruter May 8, 2026
2eb0730
Add native typed properties to OD_URL_Metric_Group
westonruter May 8, 2026
3dee81d
Add native typed properties to OD_URL_Metric_Group_Collection
westonruter May 8, 2026
2565e27
Add native typed properties to OD_Tag_Visitor_Context
westonruter May 8, 2026
500ece2
Add native typed properties to OD_Template_Optimization_Context
westonruter May 8, 2026
0c35e17
Add native typed properties to OD_URL_Metric_Store_Request_Context
westonruter May 8, 2026
65cb28c
Add native typed properties to OD_URL_Metric
westonruter May 8, 2026
7f02300
Add native typed properties to OD_Element
westonruter May 8, 2026
d7dc8e0
Add native typed properties to small OD classes
westonruter May 8, 2026
1b6b942
Add native typed properties to image-prioritizer tag visitors
westonruter May 8, 2026
2f0fc6d
Add native typed property to Embed_Optimizer_Tag_Visitor
westonruter May 8, 2026
a8b58ae
Add native typed property to PLSR_URL_Pattern_Prefixer
westonruter May 8, 2026
5260154
Add native typed properties to performance-lab server-timing classes
westonruter May 8, 2026
2aea571
Add native typed properties to view-transitions classes
westonruter May 8, 2026
6a0ce79
Require native property type hints across plugin source
westonruter May 8, 2026
8f3b90a
Convert single-expression closures to arrow functions in optimization…
westonruter May 8, 2026
884f24f
Convert single-expression closures to arrow functions in performance-lab
westonruter May 8, 2026
74a704e
Convert single-expression closures to arrow functions in image-priori…
westonruter May 8, 2026
1ae6374
Convert single-expression closure to arrow function in speculation-rules
westonruter May 8, 2026
f6cb8a2
Convert single-expression closures to arrow functions in web-worker-o…
westonruter May 8, 2026
200b0cc
Convert single-expression closure to arrow function in view-transitions
westonruter May 8, 2026
71430b3
Simplify boolean logic in plvt_register_view_transition_animations()
westonruter May 8, 2026
ea9906a
Remove redundant type hint
westonruter May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add native typed properties to OD_Template_Optimization_Context 
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
  • Loading branch information
@westonruter @claude
westonruter and claude committed May 8, 2026
commit 500ece208ad2b11ad8f5cb9ccee6934a3ce02f31
10 changes: 5 additions & 5 deletions plugins/optimization-detective/class-od-template-optimization-context.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ final class OD_Template_Optimization_Context {
* @since 1.0.0
* @var OD_URL_Metric_Group_Collection
*/
private $url_metric_group_collection;
private OD_URL_Metric_Group_Collection $url_metric_group_collection;

/**
* ID for the od_url_metrics post which provided the URL Metrics in the collection.
Expand All @@ -43,31 +43,31 @@ final class OD_Template_Optimization_Context {
* @since 1.0.0
* @var positive-int|null
*/
private $url_metrics_id;
private ?int $url_metrics_id;

/**
* Normalized query vars.
*
* @since 1.0.0
* @var array<string, mixed>
*/
private $normalized_query_vars;
private array $normalized_query_vars;

/**
* Slug for the od_url_metrics post.
*
* @since 1.0.0
* @var non-empty-string
*/
private $url_metrics_slug;
private string $url_metrics_slug;

/**
* Link collection.
*
* @since 1.0.0
* @var OD_Link_Collection
*/
private $link_collection;
private OD_Link_Collection $link_collection;

/**
* Constructor.
Expand Down