Select the smaller image size from the list of available sources#233
Closed
jjgrainger wants to merge 2 commits into
Closed
Select the smaller image size from the list of available sources#233jjgrainger wants to merge 2 commits into
jjgrainger wants to merge 2 commits into
Conversation
mitogh
reviewed
Mar 17, 2022
| } | ||
|
|
||
| // Return the resized image sources. | ||
| if ( isset( $metadata['sizes'][ $size ]['sources'] ) && ! empty( $metadata['sizes'][ $size ]['sources'] ) ) { |
Member
There was a problem hiding this comment.
In this case empty works simiarly to isset so you can avoid the isset call.
Suggested change
| if ( isset( $metadata['sizes'][ $size ]['sources'] ) && ! empty( $metadata['sizes'][ $size ]['sources'] ) ) { | |
| if ( ! empty( $metadata['sizes'][ $size ]['sources'] ) ) { |
| } | ||
|
|
||
| // Return an empty array if no sources found. | ||
| return []; |
Member
There was a problem hiding this comment.
We are using the long syntax array for arrays due to WP styleguide.
Suggested change
| return []; | |
| return array(); |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #186 Select the smaller image size from the list of available sources
Relevant technical choices
Checklist
[Focus]orInfrastructurelabel.[Type]label.no milestonelabel.