Skip to content

Fire actions before and after Optimization Detective processes a document #1919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
westonruter merged 16 commits into from
Mar 15, 2025
Merged

Fire actions before and after Optimization Detective processes a document #1919

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
abdefc0
Move OD initialization to wp action instead of output buffer callback
westonruter Mar 12, 2025
64d63da
Add od_start_template_optimization action
westonruter Mar 12, 2025
3b0f696
Initiaize OD objects at template_include filter
westonruter Mar 12, 2025
f7da494
Introduce OD_Template_Optimization_Context
westonruter Mar 12, 2025
51feaad
Add link collection to context
westonruter Mar 12, 2025
0ad7f79
Reuse template optimization context in od_optimize_template_output_bu…
westonruter Mar 12, 2025
8bcfc13
Finalize the tag registry after the od_register_tag_visitors action h…
westonruter Mar 13, 2025
a57391d
Add TODO in Image_Prioritizer_Background_Image_Styled_Tag_Visitor
westonruter Mar 13, 2025
6abee9c
Go back to initializing in footer but add action before/after optimiz…
westonruter Mar 13, 2025
09d7af7
Rename variable make it distinct from other context
westonruter Mar 13, 2025
0d8cb65
Use phpdoc to declare that the post ID is a positive-int|null
westonruter Mar 13, 2025
38a4c6b
Add tests and fix bug with adding links at finish action
westonruter Mar 14, 2025
5d12ef7
Add docs for requirement for valid HTML passed into methods
westonruter Mar 14, 2025
5da134c
Merge branch 'trunk' into update/od-initialization-timing
westonruter Mar 14, 2025
53a91a2
Remove append_head_html() and append_body_html() methods from OD_Temp…
westonruter Mar 14, 2025
a01d760
Merge branch 'trunk' into update/od-initialization-timing
westonruter Mar 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add TODO in Image_Prioritizer_Background_Image_Styled_Tag_Visitor
  • Loading branch information
@westonruter
westonruter committed Mar 13, 2025
commit a57391d7138bf29505f7ad75a0bc41210d79d219
1 change: 1 addition & 0 deletions plugins/image-prioritizer/class-image-prioritizer-background-image-styled-tag-visitor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,7 @@ private function get_common_lcp_element_external_background_image( OD_URL_Metric
private function maybe_preload_external_lcp_background_image( OD_Tag_Visitor_Context $context ): void {
// Gather the tuples of URL Metric group and the common LCP element external background image.
// Note the groups of URL Metrics do not change across invocations, we just need to compute this once for all.
// TODO: Instead of populating this here, it could be done once per invocation during the od_start_template_optimization action since the page's OD_URL_Metric_Group_Collection is available there.

@westonruter westonruter Mar 13, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #1921

if ( ! is_array( $this->group_common_lcp_element_external_background_images ) ) {
$this->group_common_lcp_element_external_background_images = array();
foreach ( $context->url_metric_group_collection as $group ) {
Expand Down