Skip to content

Eliminate varying URL Metrics by logged-in state and discontinue disabling optimization by default for admins #1788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
westonruter merged 2 commits into from
Jan 13, 2025
Merged

Eliminate varying URL Metrics by logged-in state and discontinue disabling optimization by default for admins #1788

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8737c8f
Eliminate varying URL Metrics by logged-in state
westonruter Jan 10, 2025
4c1aa71
Eliminate non-admin requirement for optimization
westonruter Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Eliminate varying URL Metrics by logged-in state
  • Loading branch information
@westonruter
westonruter committed Jan 10, 2025
commit 8737c8f35872f2d3c5f7c25596c95af07f363566
5 changes: 0 additions & 5 deletions plugins/optimization-detective/storage/data.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,11 +77,6 @@ function od_get_normalized_query_vars(): array {
);
}

// Vary URL Metrics by whether the user is logged in since additional elements may be present.
if ( is_user_logged_in() ) {
$normalized_query_vars['user_logged_in'] = true;
}

return $normalized_query_vars;
}

Expand Down
2 changes: 1 addition & 1 deletion plugins/optimization-detective/tests/storage/test-data.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ public function data_provider_test_od_get_normalized_query_vars(): array {
'set_up' => function (): array {
wp_set_current_user( self::factory()->user->create( array( 'role' => 'subscriber' ) ) );
$this->go_to( home_url( '/' ) );
return array( 'user_logged_in' => true );
return array();
},
),
);
Expand Down