Skip to content

Allow URL metric schema to be extended #1492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
westonruter merged 17 commits into from
Sep 13, 2024
Merged

Allow URL metric schema to be extended #1492

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
a52381d
Allow URL metric schema to be extended
westonruter Aug 21, 2024
e244b22
Add get() and __get() methods to OD_URL_Metric
westonruter Aug 21, 2024
079e6d9
Account for type being an array
westonruter Aug 22, 2024
bbc97dc
Add od_url_metric_collected action
westonruter Aug 22, 2024
70fd825
Add todos related to store_url_metric()
westonruter Aug 22, 2024
381c829
Adopt Yoast SEO scheme for filter _doing_it_wrong
westonruter Sep 6, 2024
e85c683
Fix and clarify message for disallowed required property in extended …
westonruter Sep 6, 2024
0cc9103
Add sanitization in addition to validation to ensure expected PHP types
westonruter Sep 6, 2024
00d57b4
Persist unknown properties in stored URL Metrics but reject in new UR…
westonruter Sep 7, 2024
22711e4
Add return description
westonruter Sep 10, 2024
384fa53
Use properties instead of get methods
westonruter Sep 10, 2024
ed58151
Replace remaining use of get_timestamp
westonruter Sep 10, 2024
aa1e663
Disallow default value for schema
westonruter Sep 10, 2024
8917ce9
Explicitly fork rest_default_additional_properties_to_false()
westonruter Sep 10, 2024
907d8c3
Add return description for magic getter
westonruter Sep 10, 2024
0db296f
Eliminate magic getter
westonruter Sep 11, 2024
ea28aa1
Merge branch 'trunk' of https://github.com/WordPress/performance into…
westonruter Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix and clarify message for disallowed required property in extended … 
…schema
  • Loading branch information
@westonruter
westonruter committed Sep 6, 2024
commit e85c68337419bc512dd5f80cfed1c6e4f67a6b29
6 changes: 3 additions & 3 deletions plugins/optimization-detective/class-od-url-metric.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,9 +318,9 @@ protected static function extend_schema_with_optional_properties( array $propert
$doing_it_wrong(
sprintf(
/* translators: 1: property name, 2: 'required' */
__( 'Supplied schema property "%1$s" with truthy for "%2$s". All properties must be optional.', 'optimization-detective' ),
'type',
$property_key
__( 'Supplied schema property "%1$s" has a truthy value for "%2$s". All extended properties must be optional so that URL Metrics are not all immediately invalidated once an extension is deactivated..', 'optimization-detective' ),
$property_key,
'required'
)
);
}
Expand Down