Skip to content

Ensure the entire template is passed to the output buffer callback for Optimization Detective to process #1317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
westonruter merged 16 commits into from
Aug 8, 2024
Merged

Ensure the entire template is passed to the output buffer callback for Optimization Detective to process #1317

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
b3ce59e
Try considering PHP_OUTPUT_HANDLER_FINAL in output buffer callback
westonruter Jun 24, 2024
13e068d
Iterate on output buffer handling
westonruter Aug 2, 2024
523fc7a
Update test-optimization.php
nextend Aug 2, 2024
3235f3b
Merge pull request #1428 from nextend/update/ob-handling
westonruter Aug 6, 2024
15ca2f0
Remove final ob_end_clean() and add ob_get_level() assertions
westonruter Aug 6, 2024
78967f5
Merge branch 'trunk' of https://github.com/WordPress/performance into…
westonruter Aug 6, 2024
f218dc8
Allow output buffer to be cleaned but not flushed
westonruter Aug 6, 2024
0b4f2cd
Allow output buffer to be removable
westonruter Aug 6, 2024
2c6ec0c
Use bitwise XOR on the standard flags to remove the flushable flag
westonruter Aug 6, 2024
35085e8
Ensure only HTML documents are processed by Optimization Detective
westonruter Aug 6, 2024
364fa43
Remove assert() checks
westonruter Aug 6, 2024
1b62c1a
Avoid sending Server-Timing header when buffer is being cleaned
westonruter Aug 6, 2024
26e859d
Fix passing arg name to _doing_it_wrong()
westonruter Aug 6, 2024
21ebb97
Improve escaping output by wrapping entire string in esc_html()
westonruter Aug 6, 2024
8cbcbd6
Merge pull request #1443 from WordPress/fix/server-timing-after-ob-clean
Aug 7, 2024
85e9c2b
Merge pull request #1442 from WordPress/fix/od-processing-non-html-re…
Aug 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Improve escaping output by wrapping entire string in esc_html()
  • Loading branch information
@westonruter
westonruter committed Aug 6, 2024
commit 21ebb9744efdbfabbc022e37deb8128ed5bd5ac9
8 changes: 4 additions & 4 deletions plugins/performance-lab/includes/server-timing/class-perflab-server-timing.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ public function register_metric( string $metric_slug, array $args ): void {
_doing_it_wrong(
__METHOD__,
/* translators: %s: metric slug */
sprintf( esc_html__( 'A metric with the slug %s is already registered.', 'performance-lab' ), esc_attr( $metric_slug ) ),
esc_html( sprintf( __( 'A metric with the slug %s is already registered.', 'performance-lab' ), $metric_slug ) ),
''
);
return;
Expand All @@ -71,7 +71,7 @@ public function register_metric( string $metric_slug, array $args ): void {
_doing_it_wrong(
__METHOD__,
/* translators: %s: WordPress action name */
sprintf( esc_html__( 'The method must be called before or during the %s action.', 'performance-lab' ), 'perflab_server_timing_send_header' ),
esc_html( sprintf( __( 'The method must be called before or during the %s action.', 'performance-lab' ), 'perflab_server_timing_send_header' ) ),
''
);
return;
Expand All @@ -88,7 +88,7 @@ public function register_metric( string $metric_slug, array $args ): void {
_doing_it_wrong(
__METHOD__,
/* translators: %s: PHP parameter name */
sprintf( esc_html__( 'The %s argument is required and must be a callable.', 'performance-lab' ), 'measure_callback' ),
esc_html( sprintf( __( 'The %s argument is required and must be a callable.', 'performance-lab' ), 'measure_callback' ) ),
''
);
return;
Expand All @@ -97,7 +97,7 @@ public function register_metric( string $metric_slug, array $args ): void {
_doing_it_wrong(
__METHOD__,
/* translators: %s: PHP parameter name */
sprintf( esc_html__( 'The %s argument is required and must be a string.', 'performance-lab' ), 'access_cap' ),
esc_html( sprintf( __( 'The %s argument is required and must be a string.', 'performance-lab' ), 'access_cap' ) ),
''
);
return;
Expand Down