Skip to content

Media Editor: Make zoom floor coverage-aware instead of fixed at 1x #78222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ramonjd merged 5 commits into from
May 19, 2026
Merged

Media Editor: Make zoom floor coverage-aware instead of fixed at 1x #78222

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
958312b
Allow the media editor cropper to lower the effective minimum zoom be…
ramonjd May 13, 2026
17b1793
Allow the media editor cropper to use coverage-aware minimum zoom val…
ramonjd May 13, 2026
b5d6b20
Update README and type definitions to reflect coverage-aware zoom beh…
ramonjd May 19, 2026
8f1b7ba
Enhance zoom functionality in image editor by introducing ABSOLUTE_MI…
ramonjd May 19, 2026
c765ed8
Refactor cropperReducer tests to enhance image selection preservation…
ramonjd May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Refactor cropperReducer tests to enhance image selection preservation… 
… logic. Adjust crop and zoom calculations for improved test accuracy, ensuring expected uncapped zoom values remain within MAX_ZOOM constraints. Remove unnecessary pass count tracking for cleaner test execution.
  • Loading branch information
@ramonjd
ramonjd committed May 19, 2026
commit c765ed82c0f48a201253bf18d822d8be4459d04f
30 changes: 8 additions & 22 deletions packages/media-editor/src/image-editor/core/test/state.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,15 +355,14 @@ describe( 'cropperReducer — SETTLE_CROP', () => {
} );

it( 'preserves image selection across 50 random crop/zoom/pan combos', () => {
let passCount = 0;
let skippedCappedCount = 0;
for ( let i = 0; i < 50; i++ ) {
// Generate deterministic-ish crop rects.
const cropW = 0.15 + ( ( i * 7 ) % 8 ) / 10;
const cropH = 0.15 + ( ( i * 11 ) % 8 ) / 10;
// Generate deterministic-ish crop rects in the preservation
// regime. Capped zoom behavior is covered by a dedicated test.
const cropW = 0.4 + ( ( i * 7 ) % 6 ) / 10;
const cropH = 0.4 + ( ( i * 11 ) % 6 ) / 10;
const cropX = Math.min( ( ( i * 3 ) % 10 ) / 10, 1 - cropW );
const cropY = Math.min( ( ( i * 5 ) % 10 ) / 10, 1 - cropH );
const zoom = 1 + ( ( i * 13 ) % 30 ) / 10;
const zoom = 1 + ( ( i * 13 ) % 12 ) / 10;
const panX = ( ( ( i * 17 ) % 20 ) - 10 ) / 100;
const panY = ( ( ( i * 19 ) % 20 ) - 10 ) / 100;

Expand All @@ -384,20 +383,10 @@ describe( 'cropperReducer — SETTLE_CROP', () => {
type: 'SETTLE_CROP',
} );

const normalizedRatio =
state.cropRect.width / state.cropRect.height;
let newH = 1;
let newW = normalizedRatio;
if ( newW > 1 ) {
newW = 1;
newH = 1 / normalizedRatio;
}
const expectedUncappedZoom =
state.zoom * ( newH / state.cropRect.height );
if ( expectedUncappedZoom > MAX_ZOOM ) {
skippedCappedCount++;
continue;
}
state.zoom /
Math.max( state.cropRect.width, state.cropRect.height );
expect( expectedUncappedZoom ).toBeLessThanOrEqual( MAX_ZOOM );

const regionBefore = getCropWorldRegion( state, IMAGE, CONTAINER );
const regionAfter = getCropWorldRegion( settled, IMAGE, CONTAINER );
Expand All @@ -422,10 +411,7 @@ describe( 'cropperReducer — SETTLE_CROP', () => {
expect( dy ).toBeLessThanOrEqual( tol );
expect( dw ).toBeLessThanOrEqual( tol );
expect( dh ).toBeLessThanOrEqual( tol );
passCount++;
}
expect( passCount + skippedCappedCount ).toBe( 50 );
expect( passCount ).toBeGreaterThan( 0 );
} );

it( 'diagonal corner drag: small crop settles accurately', () => {
Expand Down
Loading