[Spec] Allow setting automatic beacon data from cross-origin subframes. - #203
Merged
Conversation
domfarolino
reviewed
Jan 9, 2025
| /fenced-frame/automatic-beacon-use-ancestor-data.https.html | ||
| </wpt> | ||
|
|
||
| TODO: Add the following tests: |
Collaborator
There was a problem hiding this comment.
This is blocking merge right?
Collaborator
Author
There was a problem hiding this comment.
Yeah. This isn't ready for review yet. I just uploaded this so I could see a visual diff.
I'm also running into issues with the tests not being found. I tried running bikeshed update --skip-manifest and got this error:
FATAL ERROR: Bikeshed currently only knows how to handle WPT v8 manifest data, but got v9. Please report this to the maintainer!
I think I have the latest release installed (4.2.8) so adding any new WPTs to the spec might be blocked until that gets patched.
VergeA
reviewed
Jan 17, 2025
VergeA
reviewed
Jan 17, 2025
VergeA
approved these changes
Jan 17, 2025
domfarolino
approved these changes
Jan 20, 2025
domfarolino
left a comment
Collaborator
There was a problem hiding this comment.
I'm happy to defer to @VergeA's review here since the annals of the cross-origin automatic beacon work is slightly beyond me at this point, but from looking at the PR nothing major sticks out.
blu25
marked this pull request as ready for review
January 22, 2025 15:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies the automatic beacon algorithms to support data being set from frames that are cross-origin to the fenced frame config's mapped URL. More specifically, this makes the following modifications:
setReportEventDataForAutomaticBeacons()is modified to allow data to be set from cross-origin subframes, but only if the data'scrossOriginExposedparameter is set totrue.snapshot automatic beacon mappingtype is introduced that contains 2 mappings. The first mapping is the same as the existingautomatic beacon data map. The second mapping only contains automatic beacon data whosecrossOriginExposedparameter is set to true. This is needed since, as part of this change, cross-origin subframes that trigger automatic beacons will now use the first cross-origin exposed data it finds up the frame tree, versus the first data it finds regardless of whether it is cross-origin exposed or not (which it wouldn't be able to use).attempt to send an automatic beaconalgorithm now checks either the "all data mapping" or the "cross-origin only mapping" based on whether the automatic beacon initiator is cross-origin to the fenced frame config's mapped URL. This will ensure that if an ancestor has usable data, it won't accidentally grab data from a closer ancestor that can't be used. This also has a side effect of letting us remove the|should send beacon with data|variable, as the same behavior is now obtained by simply checking the cross-origin only data mapping.get the automatic beacon data mapping to useis renamed and modified to read data into both the regular mapping and the cross-origin only mapping.Preview | Diff