Feature/run legacy tests in build#13
Merged
ThatRendle merged 5 commits intoApr 27, 2021
Merged
Conversation
Contributor
|
LGTM. Thanks! |
ThatRendle
added a commit
that referenced
this pull request
Jul 19, 2021
* Original package has been deprecated this is the replacement. (#9) Co-authored-by: TheRubble <therubble@hotmail.com> * Allow the client to validate the remote certificate, useful in development and self certificate scenarios (#8) Co-authored-by: TheRubble <therubble@hotmail.com> Co-authored-by: Mark Rendle <mark@rendlelabs.com> * Adding basic docs for MVC Fullframework. (#7) Co-authored-by: TheRubble <therubble@hotmail.com> * Using statement is incorrect, prevents the build from working. (#11) * Feature/improving test coverage (#12) * CookieTests * Added basic tests before fixing some bugs. Co-authored-by: TheRubble <therubble@hotmail.com> * Feature/run legacy tests in build (#13) * Adding console runner and changes to the build. * Parallel the build and add the test runner. * Switched to release. * Testing the build. * Reverting test change. Co-authored-by: TheRubble <therubble@hotmail.com> Co-authored-by: TheRubble <482262+TheRubble@users.noreply.github.com> Co-authored-by: TheRubble <therubble@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've not removed the net5 build, I wasn't sure how you'd feel about that. I've also not changed the build that runs on main as I thought I'd get your feedback.
This now runs the legacy unit tests as part of the PR onto develop.