Add strict typings via TypeScript#10
Merged
Merged
Conversation
Collaborator
|
@tgriesser Absolutely interested, thank you! Tarn was basically created for knex and I think it should follow the direction knex takes. I'll review and merge this a bit later if that's okay? |
Contributor
Author
|
Sure thing, no rush at all. |
Contributor
Author
|
Up to you if you want to |
Collaborator
|
@tgriesser Feel free to push straight to master in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @koskimas not sure if this is something you're interested in, but as I'm preparing a path forward for knex to begin to use TypeScript for things I was looking at what dependencies have type definitions via DefinitelyTyped. As tarn didn't I thought I'd make a PR to add them, but then instead took a few minutes and added types to the whole module.
As you can probably tell from the diff, there aren't any implementation changes, just a few things around the emitted
require's. If you'd rather keep things simpler in pure JS with no build step, I can just consolidate all of the type definitions into a singled.tsand reopen with a PR for that.