Fix for empty base path causing warnings#18
Merged
jdpanderson merged 1 commit intomasterfrom Sep 1, 2020
Merged
Conversation
Member
|
Looks good to me. Travis is failing some legacy PHP versions for what looks like infrastructure reasons, so I'm re-running those jobs to see if they start passing. |
We've been seeing warnings like these: ``` PHP Warning: strpos(): Empty needle in /vendor/vectorface/snappy-router/src/Vectorface/SnappyRouter/Handler/ControllerHandler.php on line 162 ```
0886396 to
257fe2a
Compare
jdpanderson
approved these changes
Sep 1, 2020
Member
jdpanderson
left a comment
There was a problem hiding this comment.
Looks like it should work cleanly with the if statement below it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've been seeing warnings like these:
If the needle is an empty string, we should skip this code path.