Skip to content

Fix choropleth horizontal line artifacts on projected maps #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cvanelteren merged 2 commits into from
Mar 30, 2026
Merged

Fix choropleth horizontal line artifacts on projected maps #668

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a93643
Fix choropleth horizontal line artifacts on projected maps
cvanelteren Mar 30, 2026
b4cafca
Black
cvanelteren Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Black
  • Loading branch information
@cvanelteren
cvanelteren committed Mar 30, 2026
commit b4cafcad289776519a71be20413e31451976e1be
18 changes: 9 additions & 9 deletions ultraplot/tests/test_geographic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1137,9 +1137,9 @@ def test_choropleth_antimeridian_no_horizontal_artifacts():
assert len(paths) >= 1
codes = paths[0].codes
moveto_count = (codes == 1).sum() # Path.MOVETO == 1
assert moveto_count >= 2, (
"Antimeridian-crossing polygon should be split into multiple sub-paths"
)
assert (
moveto_count >= 2
), "Antimeridian-crossing polygon should be split into multiple sub-paths"
uplt.close(fig)


Expand All @@ -1163,9 +1163,9 @@ def test_choropleth_project_geometry_non_cylindrical():
# Verify no inf/nan in projected vertices
for path in paths:
verts = path.vertices
assert np.all(np.isfinite(verts)), (
f"Projected path has non-finite vertices on {proj!r} projection"
)
assert np.all(
np.isfinite(verts)
), f"Projected path has non-finite vertices on {proj!r} projection"
uplt.close(fig)


Expand All @@ -1182,9 +1182,9 @@ def test_choropleth_country_antimeridian_renders():

for path in coll.get_paths():
verts = path.vertices
assert np.all(np.isfinite(verts)), (
f"Russia choropleth path has non-finite vertices on {proj!r}"
)
assert np.all(
np.isfinite(verts)
), f"Russia choropleth path has non-finite vertices on {proj!r}"
uplt.close(fig)


Expand Down
Loading