fix: remove @infer_bindings from ConnectionsService.retrieve methods#662
Merged
Conversation
akshaylive
approved these changes
Oct 9, 2025
akshaylive
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. We need to open an issue to fix this throughout the codebase after consultation with Pufu.
Specifically, we need to avoid treating name and folder_path as special values. Instead, we could use simple dictionary-merge to make infer_bindings more generic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a minor update to the
ConnectionsServiceclass by removing the@infer_bindingsdecorator from two methods. This change likely simplifies the method signatures or modifies how resource bindings are handled, but does not affect the overall functionality of the service.