feat: progress on parallelization of eval runs#647
Merged
Conversation
55716ea to
7d8c55c
Compare
24d7226 to
c53c83b
Compare
c53c83b to
e87a79c
Compare
f9f4487 to
e860386
Compare
753d89c to
7c2d91e
Compare
Closed
akshaylive
reviewed
Oct 8, 2025
radu-mocanu
reviewed
Oct 9, 2025
radu-mocanu
reviewed
Oct 9, 2025
d0f1a8c to
a212f4f
Compare
1191661 to
a5dfafd
Compare
akshaylive
requested changes
Oct 10, 2025
a5dfafd to
303d7ae
Compare
radu-mocanu
reviewed
Oct 10, 2025
eb0bbd9 to
ad486d6
Compare
ad486d6 to
baae301
Compare
radu-mocanu
reviewed
Oct 10, 2025
58522f1 to
b28fe7c
Compare
8450abe to
d5aa835
Compare
d5aa835 to
c7bcd9d
Compare
akshaylive
reviewed
Oct 10, 2025
| result = await self._execute_eval(eval_item, evaluators, event_bus) | ||
|
|
||
| # Store result with its index to maintain order | ||
| results_dict[index] = result |
Collaborator
There was a problem hiding this comment.
Nit: I personally like the semaphore approach and avoids anti-patterns like this mutation. We can address this later.
akshaylive
approved these changes
Oct 10, 2025
akshaylive
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. We'll need to follow up with setting the optimal default value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did a test with 10 evaluations following config:
and varied the number of workers and found this as the general time trends:
the time gained is pretty dismal, but something is better than nothing for starters ?