refactor: authentication logic#644
Merged
Merged
Conversation
Collaborator
|
let s squash into 1 commit and add description please |
radu-mocanu
reviewed
Oct 7, 2025
radu-mocanu
reviewed
Oct 7, 2025
radu-mocanu
reviewed
Oct 7, 2025
radu-mocanu
reviewed
Oct 7, 2025
radu-mocanu
reviewed
Oct 7, 2025
radu-mocanu
reviewed
Oct 7, 2025
radu-mocanu
reviewed
Oct 7, 2025
radu-mocanu
reviewed
Oct 7, 2025
radu-mocanu
reviewed
Oct 7, 2025
radu-mocanu
reviewed
Oct 7, 2025
3863e23 to
9e3ce06
Compare
radu-mocanu
approved these changes
Oct 10, 2025
9e3ce06 to
d4db38d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the authentication logic to better support both interactive and client credentials flows.
The main changes are in the
AuthServiceandPortalServicecode, which now handle token management andauthentication flow more cleanly. Added support for external applications with a new service for managing client
credentials authentication.
This PR also includes a new
asset-modifier-agentsample that demonstrates how to use the SDK with external applicationauthentication. It connects to Orchestrator, retrieves an asset, and validates its value.
Updated tests to cover the new authentication flows and external application service.