Skip to content

Fixed incorrect variable declarations in some cases (#944) #952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Perryvw merged 1 commit into from
Dec 21, 2020
Merged

Fixed incorrect variable declarations in some cases (#944) #952

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/transformation/utils/lua-ast.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,9 @@ export function createLocalOrExportedOrGlobalDeclaration(
if (scope.type === ScopeType.Switch || (!isFunctionDeclaration && hasMultipleReferences(scope, lhs))) {
// Split declaration and assignment of identifiers that reference themselves in their declaration
declaration = lua.createVariableDeclarationStatement(lhs, undefined, tsOriginal);
assignment = lua.createAssignmentStatement(lhs, rhs, tsOriginal);
if (rhs) {
assignment = lua.createAssignmentStatement(lhs, rhs, tsOriginal);
}
} else {
declaration = lua.createVariableDeclarationStatement(lhs, rhs, tsOriginal);
}
Expand Down
11 changes: 11 additions & 0 deletions test/unit/hoisting.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,3 +254,14 @@ test("Hoisting Shorthand Property", () => {
return foo();`;
expect(util.transpileAndExecute(code)).toBe("foobar");
});

// https://github.com/TypeScriptToLua/TypeScriptToLua/issues/944
test("Hoisting variable without initializer", () => {
util.testFunction`
function foo() {
return x;
}
let x: number;
return foo();
`.expectToMatchJsResult();
});