Count only messages the inbox can open - #385
Merged
Merged
Conversation
…ssages when it links
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Messages pill counted inbound SMS and Telegram rows with no customer, which the inbox never lists and can never mark read, so a stranded pair kept it at 2. SMS and Telegram now count only rows with a customer; WhatsApp is unchanged because unmatched numbers are listed. When a Telegram chat links through /start, its earlier customer-less messages are attached to the customer. A data migration does the same for rows already in the database.
Unit tests for the count and the webhook's adoption of earlier messages.