Line and paragraph spacing in the email theme - #384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subject and theme gets two steps under Typography: line spacing (compact, normal, relaxed) and paragraph spacing (tight, normal, loose). Body lines follow the step, headings and small print scale with it, and the gap between paragraphs and text blocks follows the paragraph step. Both are optional on the template, so every saved template reads as normal, which is what it looked like before.
Unit tests for the spacing table, the renderer and the stored template; the designer e2e spec changes both steps and reads them off the preview.