update aria-checked messages #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add additional logic for checkbox and radio buttons with aria-checked.
4 tasks
Collaborator
|
Hi @scottaohara, I haven't tested it, but it looks like it would work. I would move the return false statement to one statement at the end of the section for checkboxes, rather than having a separate statement for the if/else sections. All looks good with the radio part. |
Contributor
Author
|
Thanks @gezlemon. made that change re: return false. |
Collaborator
|
Thanks, @scottaohara I've updated the bookmarklet. |
Contributor
Author
|
heya @gezlemon. just making sure the push was made so that the bookmarklet updates. not noticing a difference when performing a test right now |
Collaborator
|
Hi @scottaohara, sorry about that. I've just loaded it up again and tested it, and it's using the updated script now. |
Contributor
Author
|
thank you gez. looks good now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add additional logic for checkbox and radio buttons with aria-checked.
@gezlemon please let me know if this updated logic will work correctly.