Skip to content

fix: isolate TypeScript test output - #11503

Merged
TkDodo merged 1 commit into
mainfrom
tkdodo/fix/isolate-type-test-output
Sep 15, 2026
Merged

fix: isolate TypeScript test output#11503
TkDodo merged 1 commit into
mainfrom
tkdodo/fix/isolate-type-test-output

Conversation

@TkDodo

@TkDodo TkDodo commented Sep 15, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

🎯 Changes

Prevent concurrent type tests from writing to the same dependency declarations and build metadata. Use --project, compile dependencies first through Nx, and give each compiler version separate output and metadata paths. Parallel execution stays enabled.

Type tests now read compiled dependency declarations instead of rebuilding dependency source. Package clean scripts remove the test outputs.

Validation: compile/type checks passed for all 26 packages with caching disabled, plus formatting and diff checks. Earlier full PR checks stopped on npm pack failures in query-core and query-devtools; the full check was not repeated after the final simplification.

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
  • I fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

  • Chores

    • Updated project compilation to build dependencies in the correct order.
    • Improved TypeScript compatibility checks across supported compiler versions by isolating their generated test artifacts, enabling parallel execution without overwriting regular build output.
    • Expanded cleanup commands to remove generated type-test cache files.
    • Updated development tooling scripts for consistent project-based compilation.

  • Documentation

    • Added guidance explaining compilation, dependency handling, parallel type testing, and cleanup behavior.

@TkDodo
TkDodo requested a review from a team as a code owner September 15, 2026 18:36
@coderabbitai

coderabbitai Bot commented Sep 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: b439caa6-a23a-4a22-80f6-a8e39ccf6cb2

📥 Commits

Reviewing files that changed from the base of the PR and between d63afc7 and 9b49fc0.

📒 Files selected for processing (28)
  • CONTRIBUTING.md
  • nx.json
  • packages/angular-query-experimental/package.json
  • packages/angular-query-persist-client/package.json
  • packages/eslint-plugin-query/package.json
  • packages/lit-query/package.json
  • packages/preact-query-devtools/package.json
  • packages/preact-query-persist-client/package.json
  • packages/preact-query/package.json
  • packages/query-async-storage-persister/package.json
  • packages/query-broadcast-client-experimental/package.json
  • packages/query-core/package.json
  • packages/query-devtools/package.json
  • packages/query-persist-client-core/package.json
  • packages/query-sync-storage-persister/package.json
  • packages/query-test-utils/package.json
  • packages/react-query-devtools/package.json
  • packages/react-query-next-experimental/package.json
  • packages/react-query-persist-client/package.json
  • packages/react-query/package.json
  • packages/solid-query-devtools/package.json
  • packages/solid-query-persist-client/package.json
  • packages/solid-query/package.json
  • packages/svelte-query-devtools/package.json
  • packages/svelte-query-persist-client/package.json
  • packages/svelte-query/package.json
  • packages/vue-query-devtools/package.json
  • packages/vue-query/package.json

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

Walkthrough

Changes

TypeScript build flow

Layer / File(s) Summary
Build orchestration and documentation
CONTRIBUTING.md, nx.json, packages/vue-query-devtools/package.json		 Nx now orders dependent compile targets. Vue devtools adds Nx build dependencies. The test documentation describes separate compile and type-test outputs.
Explicit package compilation
packages/*/package.json		 Package compile scripts now use explicit project configurations. Configured clean scripts also remove .cache/test-types.
Version-specific type-test outputs
packages/*/package.json		 Type-test scripts now write to per-TypeScript-version cache directories with matching build-info files. Selected Solid packages add current-version checks and remove redundant compile steps.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Bug fix

Suggested reviewers: tannerlinsley

Merge Risk: ⚪ Minimal · up to 9b49f

The build and type-test configuration changes do not show a concrete current-head failure or merge-blocking risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: isolating TypeScript test output.
Description check ✅ Passed The description explains the change, motivation, validation, checklist status, and no-release impact. It is complete and aligned with the repository template.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch tkdodo/fix/isolate-type-test-output

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloud Bot commented Sep 15, 2026 •
edited
Loading

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 9b49fc0

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 5m 13s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 49s View ↗

☁️ Nx Cloud last updated this comment at 2026-09-15 18:42:49 UTC

@github-actions

github-actions Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

5 package(s) bumped directly, 20 bumped as dependents.

🟨 Minor bumps

Package Version Reason
@tanstack/query-core 5.102.8 → 5.103.0 Changeset
@tanstack/query-devtools 5.102.8 → 5.103.0 Changeset
@tanstack/react-query-devtools 5.102.8 → 5.103.0 Changeset
@tanstack/svelte-query 6.1.48 → 6.2.0 Changeset
@tanstack/vue-query 5.102.8 → 5.103.0 Changeset
@tanstack/angular-query-experimental 5.102.8 → 5.103.0 Dependent
@tanstack/angular-query-persist-client 5.102.8 → 5.103.0 Dependent
@tanstack/eslint-plugin-query 5.102.8 → 5.103.0 Dependent
@tanstack/preact-query 5.102.8 → 5.103.0 Dependent
@tanstack/preact-query-devtools 5.102.8 → 5.103.0 Dependent
@tanstack/preact-query-persist-client 5.102.8 → 5.103.0 Dependent
@tanstack/query-async-storage-persister 5.102.8 → 5.103.0 Dependent
@tanstack/query-broadcast-client-experimental 5.102.8 → 5.103.0 Dependent
@tanstack/query-persist-client-core 5.102.8 → 5.103.0 Dependent
@tanstack/query-sync-storage-persister 5.102.8 → 5.103.0 Dependent
@tanstack/react-query 5.102.8 → 5.103.0 Dependent
@tanstack/react-query-next-experimental 5.102.8 → 5.103.0 Dependent
@tanstack/react-query-persist-client 5.102.8 → 5.103.0 Dependent
@tanstack/solid-query 5.102.8 → 5.103.0 Dependent
@tanstack/solid-query-devtools 5.102.8 → 5.103.0 Dependent
@tanstack/solid-query-persist-client 5.102.8 → 5.103.0 Dependent
@tanstack/svelte-query-devtools 6.1.48 → 6.2.0 Dependent
@tanstack/svelte-query-persist-client 6.1.48 → 6.2.0 Dependent
@tanstack/vue-query-devtools 6.1.48 → 6.2.0 Dependent

🟩 Patch bumps

Package Version Reason
@tanstack/lit-query 0.2.20 → 0.2.21 Dependent

@pkg-pr-new

pkg-pr-new Bot commented Sep 15, 2026

Copy link
Copy Markdown
More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@11503

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@11503

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@11503

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@11503

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@11503

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@11503

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@11503

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@11503

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@11503

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@11503

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@11503

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@11503

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@11503

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@11503

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@11503

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@11503

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@11503

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@11503

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@11503

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@11503

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@11503

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@11503

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@11503

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@11503

commit: 9b49fc0

@github-actions

github-actions Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
react full 11.87 KB (0%)
react minimal 8.84 KB (0%)

@TkDodo
TkDodo merged commit 58ad3e2 into main Sep 15, 2026
9 checks passed
@TkDodo
TkDodo deleted the tkdodo/fix/isolate-type-test-output branch September 15, 2026 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KevinVandy KevinVandy KevinVandy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TkDodo @KevinVandy