fix: declare devtools dependencies and enforce strict workspace checks by TkDodo · Pull Request #11501 · TanStack/query

TkDodo · 2026-09-15T16:16:11Z

add missing dependencies
adjust knip to check this

Summary by CodeRabbit

Bug Fixes
- Improved dependency declarations for the Query Devtools packages, ensuring they install correctly with strict package managers.
- Updated Devtools packaging so runtime dependencies remain bundled while required published declarations resolve properly.
- Added React 18 and 19 type compatibility for React Query Devtools.
- Declared the supported Vitest peer dependency for Query Test Utilities.
Chores
- Improved dependency analysis and validation across package builds and tests.

coderabbitai · 2026-09-15T16:16:18Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: c5d2a2df-8632-4e66-b6b8-7f61913002c8

📥 Commits

Reviewing files that changed from the base of the PR and between 12027ef and 601c564.

⛔ Files ignored due to path filters (1)

pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (9)

.changeset/small-devtools-dependencies.md
knip.json
knip.ts
nx.json
package.json
packages/query-devtools/package.json
packages/query-devtools/tsdown.config.ts
packages/query-test-utils/package.json
packages/react-query-devtools/package.json

💤 Files with no reviewable changes (1)

knip.json

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

Walkthrough

The pull request updates package dependency metadata, preserves devtools runtime bundling, replaces the Knip JSON configuration with typed rules, and makes Knip run after package builds with strict unlisted-dependency checks.

Changes

Dependency and analysis configuration

Layer / File(s)	Summary
Published dependency contracts and bundling `.changeset/...`, `packages/query-devtools/...`, `packages/query-test-utils/package.json`, `packages/react-query-devtools/package.json`	Devtools runtime dependencies are declared separately and bundled into compiled output. Declaration output excludes bundled dependencies. `vitest` and React types are declared as peer dependencies.
Typed Knip workspace configuration `knip.json`, `knip.ts`	The JSON Knip configuration is replaced by a TypeScript configuration with strict hint validation, global ignore rules, and workspace-specific settings.
Knip execution and build ordering `package.json`, `nx.json`	`test:knip` now runs strict unlisted-dependency analysis with Git-ignored files included. Nx runs package builds before the Knip target.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Bug fix

Suggested reviewers: tannerlinsley

Merge Risk: ⚪ Minimal · up to 601c5

No concrete merge-blocking behavior or release-contract issue remains identified.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description identifies the main changes but does not follow the repository template. It omits the required Changes, Checklist, and Release Impact sections and does not document testing, contributo…	Update the description to include all template sections. Complete the checklist, state whether tests were run or do not apply, confirm understanding of AI-assisted code, and indicate the release impact. Reference the generated changeset if …

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main changes: declaring devtools dependencies and enforcing stricter Knip workspace checks.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description identifies the main changes but does not follow the repository template. It omits the required Changes, Checklist, and Release Impact sections and does not document testing, contributor-guide compliance, or changeset status.

Resolution

Update the description to include all template sections. Complete the checklist, state whether tests were run or do not apply, confirm understanding of AI-assisted code, and indicate the release impact. Reference the generated changeset if the published packages are affected.

Fix all pre-merge checks with AI

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch tkdodo/fix/devtools-phantom-dependencies

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

nx-cloud · 2026-09-15T16:16:40Z

View your CI Pipeline Execution ↗ for commit 13f6c11

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	8m 24s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	51s	View ↗

☁️ Nx Cloud last updated this comment at 2026-09-15 16:28:49 UTC

github-actions · 2026-09-15T16:17:19Z

🚀 Changeset Version Preview

5 package(s) bumped directly, 20 bumped as dependents.

🟨 Minor bumps

Package	Version	Reason
`@tanstack/query-core`	5.102.8 → 5.103.0	Changeset
`@tanstack/query-devtools`	5.102.8 → 5.103.0	Changeset
`@tanstack/react-query-devtools`	5.102.8 → 5.103.0	Changeset
`@tanstack/svelte-query`	6.1.48 → 6.2.0	Changeset
`@tanstack/vue-query`	5.102.8 → 5.103.0	Changeset
`@tanstack/angular-query-experimental`	5.102.8 → 5.103.0	Dependent
`@tanstack/angular-query-persist-client`	5.102.8 → 5.103.0	Dependent
`@tanstack/eslint-plugin-query`	5.102.8 → 5.103.0	Dependent
`@tanstack/preact-query`	5.102.8 → 5.103.0	Dependent
`@tanstack/preact-query-devtools`	5.102.8 → 5.103.0	Dependent
`@tanstack/preact-query-persist-client`	5.102.8 → 5.103.0	Dependent
`@tanstack/query-async-storage-persister`	5.102.8 → 5.103.0	Dependent
`@tanstack/query-broadcast-client-experimental`	5.102.8 → 5.103.0	Dependent
`@tanstack/query-persist-client-core`	5.102.8 → 5.103.0	Dependent
`@tanstack/query-sync-storage-persister`	5.102.8 → 5.103.0	Dependent
`@tanstack/react-query`	5.102.8 → 5.103.0	Dependent
`@tanstack/react-query-next-experimental`	5.102.8 → 5.103.0	Dependent
`@tanstack/react-query-persist-client`	5.102.8 → 5.103.0	Dependent
`@tanstack/solid-query`	5.102.8 → 5.103.0	Dependent
`@tanstack/solid-query-devtools`	5.102.8 → 5.103.0	Dependent
`@tanstack/solid-query-persist-client`	5.102.8 → 5.103.0	Dependent
`@tanstack/svelte-query-devtools`	6.1.48 → 6.2.0	Dependent
`@tanstack/svelte-query-persist-client`	6.1.48 → 6.2.0	Dependent
`@tanstack/vue-query-devtools`	6.1.48 → 6.2.0	Dependent

🟩 Patch bumps

Package	Version	Reason
`@tanstack/lit-query`	0.2.20 → 0.2.21	Dependent

pkg-pr-new · 2026-09-15T16:21:14Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@11501

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@11501

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@11501

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@11501

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@11501

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@11501

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@11501

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@11501

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@11501

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@11501

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@11501

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@11501

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@11501

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@11501

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@11501

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@11501

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@11501

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@11501

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@11501

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@11501

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@11501

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@11501

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@11501

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@11501

commit: 601c564

github-actions · 2026-09-15T16:22:34Z

size-limit report 📦

Path	Size
react full	11.85 KB (0%)
react minimal	8.84 KB (0%)

fix: declare devtools dependencies and enforce strict workspace checks

13f6c11

Merge branch 'main' into tkdodo/fix/devtools-phantom-dependencies

601c564

TkDodo marked this pull request as ready for review September 15, 2026 16:18

TkDodo requested a review from a team as a code owner September 15, 2026 16:18

schiller-manuel approved these changes Sep 15, 2026

View reviewed changes

TkDodo merged commit 9567367 into main Sep 15, 2026
9 checks passed

TkDodo deleted the tkdodo/fix/devtools-phantom-dependencies branch September 15, 2026 18:03

github-actions Bot mentioned this pull request Sep 15, 2026

ci: Version Packages #11339

Merged

Navigation Menu

Uh oh!

Uh oh!

fix: declare devtools dependencies and enforce strict workspace checks - #11501

fix: declare devtools dependencies and enforce strict workspace checks#11501
TkDodo merged 2 commits into
mainfrom
tkdodo/fix/devtools-phantom-dependencies

TkDodo commented Sep 15, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Sep 15, 2026 •

edited

Loading

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

nx-cloud Bot commented Sep 15, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 15, 2026

Uh oh!

pkg-pr-new Bot commented Sep 15, 2026

Uh oh!

github-actions Bot commented Sep 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

TkDodo commented Sep 15, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Sep 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

nx-cloud Bot commented Sep 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 15, 2026

🚀 Changeset Version Preview

🟨 Minor bumps

🟩 Patch bumps

Uh oh!

pkg-pr-new Bot commented Sep 15, 2026

Uh oh!

github-actions Bot commented Sep 15, 2026

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

TkDodo commented Sep 15, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Sep 15, 2026 •

edited

Loading

nx-cloud Bot commented Sep 15, 2026 •

edited

Loading