fix: mask password when logging Redis connection URLs - #268
Merged
Merged
Conversation
|
|
|
|
Member
|
Thanks for bringing attention to this issue and contributing! 🙏 |
Member
|
Fixes #267 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redis connection URLs (including the embedded password, e.g.
redis://:PASSWORD@host:port) were logged in plaintext at startup for both the cache adapter and the websocket Redis adapter. This exposes the Redis password in server logs,docker logsoutput, and any log aggregation pipeline.Fix
Added a new
anonymizeRedisUrl()helper incommon/functions.ts, following the same masking convention as the existinganonymizePassword()helper ('********').Applied it to the three
readyevent log lines that previously logged the raw connection URL:infrastructure/cache/adapters/redis-cache.adapter.tsinfrastructure/websocket/adapters/redis.adapter.ts(PubClient and SubClient)