Switch to correct dependencies#203
Merged
etjones merged 2 commits intoSolidCode:masterfrom Jan 10, 2023
Merged
Conversation
pyproject.toml: Since poetry is used, switch to the build-system setup as documented upstream (https://python-poetry.org/docs/pyproject#poetry-and-pep-517).
pyproject.toml: Pkg_resources is used in solid/solidpython.py, hence this project depends on setuptools until the use of pkg_resources is replaced with something else.
archlinux-github
pushed a commit
to archlinux/svntogit-community
that referenced
this pull request
Jan 9, 2023
Switch to using correct dependencies. Add upstreamed patch to fix build-system and direct dependencies: SolidCode/SolidPython#203 Use unittest in check() and drop unneeded checkdepends. Open upstream ticket about missing 1.1.3 tag: SolidCode/SolidPython#202 git-svn-id: file:///srv/repos/svn-community/svn@1382173 9fca08f4-af9d-4005-b8df-a31f2cc04f65
archlinux-github
pushed a commit
to archlinux/svntogit-community
that referenced
this pull request
Jan 9, 2023
Switch to using correct dependencies. Add upstreamed patch to fix build-system and direct dependencies: SolidCode/SolidPython#203 Use unittest in check() and drop unneeded checkdepends. Open upstream ticket about missing 1.1.3 tag: SolidCode/SolidPython#202 git-svn-id: file:///srv/repos/svn-community/svn@1382173 9fca08f4-af9d-4005-b8df-a31f2cc04f65
Contributor
|
Thanks for this! I checked on the Poetry/Setuptools issues sometime in 2021, found the issues were still around, and haven't looked back since. What's the status of building with Poetry & PEP517 builders these days? |
Contributor
Author
You can use poetry for that for your own purposes. E.g. In a distribution context we use tooling with a much smaller foodprint (irt dependencies) such as pypa/build and pypa/installer though (see for the current Arch Linux PKGBUILD for further info - also the reason why I did this PR). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch to poetry-core as build-system (and remove all unused/unneeded build dependencies).
Add setuptools to dependency of the project, as it is in fact required directly (due to the use of
pkg_resources).