feat: implement new vote#30
Merged
sleepdefic1t merged 8 commits intoSolar-network:masterfrom Jun 30, 2022
Merged
Conversation
sleepdefic1t
requested changes
Jun 15, 2022
sleepdefic1t
approved these changes
Jun 17, 2022
sleepdefic1t
requested changes
Jun 17, 2022
sleepdefic1t
requested changes
Jun 17, 2022
Contributor
Author
|
Thank you everyone for your feedback. @sleepdefic1t please have a look at my latest changes. |
sleepdefic1t
requested changes
Jun 29, 2022
Contributor
Author
|
I've made these additional checks in the latest commit. |
sleepdefic1t
requested changes
Jun 30, 2022
Collaborator
sleepdefic1t
left a comment
There was a problem hiding this comment.
The final vote % must be 100%.
Please add an additional check, and test case, to enforce that values less than 100% are also rejected.
sleepdefic1t
requested changes
Jun 30, 2022
sleepdefic1t
approved these changes
Jun 30, 2022
Cactus-15-49
approved these changes
Jun 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example usage:
In a separate PR I'll bump the lib version add create CHANGELOG file to track changes for each release.